mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-12 13:55:32 +00:00
SMB2: Fix share type handling
In fs/cifs/smb2pdu.h, we have:
#define SMB2_SHARE_TYPE_DISK 0x01
#define SMB2_SHARE_TYPE_PIPE 0x02
#define SMB2_SHARE_TYPE_PRINT 0x03
Knowing that, with the current code, the SMB2_SHARE_TYPE_PRINT case can
never trigger and printer share would be interpreted as disk share.
So, test the ShareType value for equality instead.
Fixes: faaf946a7d
("CIFS: Add tree connect/disconnect capability for SMB2")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Aurelien Aptel <aaptel@suse.com>
Signed-off-by: Steve French <smfrench@gmail.com>
This commit is contained in:
parent
ecdcf622eb
commit
cd1230070a
1 changed files with 9 additions and 5 deletions
|
@ -1240,15 +1240,19 @@ SMB2_tcon(const unsigned int xid, struct cifs_ses *ses, const char *tree,
|
|||
goto tcon_exit;
|
||||
}
|
||||
|
||||
if (rsp->ShareType & SMB2_SHARE_TYPE_DISK)
|
||||
switch (rsp->ShareType) {
|
||||
case SMB2_SHARE_TYPE_DISK:
|
||||
cifs_dbg(FYI, "connection to disk share\n");
|
||||
else if (rsp->ShareType & SMB2_SHARE_TYPE_PIPE) {
|
||||
break;
|
||||
case SMB2_SHARE_TYPE_PIPE:
|
||||
tcon->ipc = true;
|
||||
cifs_dbg(FYI, "connection to pipe share\n");
|
||||
} else if (rsp->ShareType & SMB2_SHARE_TYPE_PRINT) {
|
||||
tcon->print = true;
|
||||
break;
|
||||
case SMB2_SHARE_TYPE_PRINT:
|
||||
tcon->ipc = true;
|
||||
cifs_dbg(FYI, "connection to printer\n");
|
||||
} else {
|
||||
break;
|
||||
default:
|
||||
cifs_dbg(VFS, "unknown share type %d\n", rsp->ShareType);
|
||||
rc = -EOPNOTSUPP;
|
||||
goto tcon_error_exit;
|
||||
|
|
Loading…
Reference in a new issue