mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-29 23:53:32 +00:00
scsi: qedf: Avoid reading past end of buffer
Using memcpy() from a string that is shorter than the length copied means the destination buffer is being filled with arbitrary data from the kernel rodata segment. Instead, use strncpy() which will fill the trailing bytes with zeros. This was found with the future CONFIG_FORTIFY_SOURCE feature. Cc: Daniel Micay <danielmicay@gmail.com> Signed-off-by: Kees Cook <keescook@chromium.org> Acked-by: Chad Dupuis <chad.dupuis@cavium.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
parent
0d2fc3b48b
commit
cd22874fec
1 changed files with 1 additions and 1 deletions
|
@ -2895,7 +2895,7 @@ static int __qedf_probe(struct pci_dev *pdev, int mode)
|
|||
slowpath_params.drv_minor = QEDF_DRIVER_MINOR_VER;
|
||||
slowpath_params.drv_rev = QEDF_DRIVER_REV_VER;
|
||||
slowpath_params.drv_eng = QEDF_DRIVER_ENG_VER;
|
||||
memcpy(slowpath_params.name, "qedf", QED_DRV_VER_STR_SIZE);
|
||||
strncpy(slowpath_params.name, "qedf", QED_DRV_VER_STR_SIZE);
|
||||
rc = qed_ops->common->slowpath_start(qedf->cdev, &slowpath_params);
|
||||
if (rc) {
|
||||
QEDF_ERR(&(qedf->dbg_ctx), "Cannot start slowpath.\n");
|
||||
|
|
Loading…
Reference in a new issue