mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-04 16:15:11 +00:00
staging: most: i2c: avoid polling in case of misconfig
This patch prevents the driver from falling back to polling mode in case of IRQ misconfiguration. Signed-off-by: Christian Gromm <christian.gromm@microchip.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
795ce21892
commit
cd2e7148e7
1 changed files with 10 additions and 8 deletions
|
@ -90,22 +90,24 @@ static int configure_channel(struct most_interface *most_iface,
|
||||||
}
|
}
|
||||||
|
|
||||||
if (channel_config->direction == MOST_CH_RX) {
|
if (channel_config->direction == MOST_CH_RX) {
|
||||||
dev->polling_mode = polling_req || dev->client->irq <= 0;
|
dev->polling_mode = polling_req;
|
||||||
if (!dev->polling_mode) {
|
if (!dev->polling_mode) {
|
||||||
pr_info("Requesting IRQ: %d\n", dev->client->irq);
|
if (dev->client->irq <= 0) {
|
||||||
|
pr_err("bad irq: %d\n", dev->client->irq);
|
||||||
|
return -ENOENT;
|
||||||
|
}
|
||||||
dev->rx.int_disabled = false;
|
dev->rx.int_disabled = false;
|
||||||
ret = request_irq(dev->client->irq, most_irq_handler, 0,
|
ret = request_irq(dev->client->irq, most_irq_handler, 0,
|
||||||
dev->client->name, dev);
|
dev->client->name, dev);
|
||||||
if (ret) {
|
if (ret) {
|
||||||
pr_info("IRQ request failed: %d, falling back to polling\n",
|
pr_err("request_irq(%d) failed: %d\n",
|
||||||
ret);
|
dev->client->irq, ret);
|
||||||
dev->polling_mode = true;
|
return ret;
|
||||||
}
|
}
|
||||||
|
} else if (scan_rate) {
|
||||||
|
pr_info("polling rate is %d Hz\n", scan_rate);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
if ((channel_config->direction == MOST_CH_RX) && (dev->polling_mode)) {
|
|
||||||
pr_info("Using polling at rate: %d times/sec\n", scan_rate);
|
|
||||||
}
|
|
||||||
dev->is_open[ch_idx] = true;
|
dev->is_open[ch_idx] = true;
|
||||||
|
|
||||||
return 0;
|
return 0;
|
||||||
|
|
Loading…
Reference in a new issue