mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-08 01:29:02 +00:00
selinux: fix double free
commit 65de50969a
upstream.
Clang's static analysis tool reports these double free memory errors.
security/selinux/ss/services.c:2987:4: warning: Attempt to free released memory [unix.Malloc]
kfree(bnames[i]);
^~~~~~~~~~~~~~~~
security/selinux/ss/services.c:2990:2: warning: Attempt to free released memory [unix.Malloc]
kfree(bvalues);
^~~~~~~~~~~~~~
So improve the security_get_bools error handling by freeing these variables
and setting their return pointers to NULL and the return len to 0
Cc: stable@vger.kernel.org
Signed-off-by: Tom Rix <trix@redhat.com>
Acked-by: Stephen Smalley <stephen.smalley.work@gmail.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
9a20612e47
commit
cd80735a43
1 changed files with 4 additions and 0 deletions
|
@ -2857,8 +2857,12 @@ int security_get_bools(struct selinux_state *state,
|
|||
if (*names) {
|
||||
for (i = 0; i < *len; i++)
|
||||
kfree((*names)[i]);
|
||||
kfree(*names);
|
||||
}
|
||||
kfree(*values);
|
||||
*len = 0;
|
||||
*names = NULL;
|
||||
*values = NULL;
|
||||
goto out;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue