mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 01:10:04 +00:00
[media] ddbridge: remove unneeded an NULL check
Static checkers complain about the inconsistent NULL check here. There is an unchecked dereference of "input->fe" in the call to tuner_attach_tda18271() and there is a second unchecked dereference a couple lines later when we do: input->fe2->tuner_priv = input->fe->tuner_priv; But actually "intput->fe" can't be NULL because if demod_attach_drxk() fails to allocate it, then we would have return an error code. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
This commit is contained in:
parent
f8817c9ea1
commit
cdcb12e78a
1 changed files with 2 additions and 4 deletions
|
@ -876,10 +876,8 @@ static int dvb_input_attach(struct ddb_input *input)
|
|||
return -ENODEV;
|
||||
if (tuner_attach_tda18271(input) < 0)
|
||||
return -ENODEV;
|
||||
if (input->fe) {
|
||||
if (dvb_register_frontend(adap, input->fe) < 0)
|
||||
return -ENODEV;
|
||||
}
|
||||
if (dvb_register_frontend(adap, input->fe) < 0)
|
||||
return -ENODEV;
|
||||
if (input->fe2) {
|
||||
if (dvb_register_frontend(adap, input->fe2) < 0)
|
||||
return -ENODEV;
|
||||
|
|
Loading…
Reference in a new issue