mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-29 22:02:02 +00:00
HID: hid-sensor-hub: Return error for hid_set_field() failure
[ Upstream commit edb032033d
]
In the function sensor_hub_set_feature(), return error when hid_set_field()
fails.
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
1f760c4e65
commit
cdf5e4747d
1 changed files with 9 additions and 4 deletions
|
@ -210,16 +210,21 @@ int sensor_hub_set_feature(struct hid_sensor_hub_device *hsdev, u32 report_id,
|
||||||
buffer_size = buffer_size / sizeof(__s32);
|
buffer_size = buffer_size / sizeof(__s32);
|
||||||
if (buffer_size) {
|
if (buffer_size) {
|
||||||
for (i = 0; i < buffer_size; ++i) {
|
for (i = 0; i < buffer_size; ++i) {
|
||||||
hid_set_field(report->field[field_index], i,
|
ret = hid_set_field(report->field[field_index], i,
|
||||||
(__force __s32)cpu_to_le32(*buf32));
|
(__force __s32)cpu_to_le32(*buf32));
|
||||||
|
if (ret)
|
||||||
|
goto done_proc;
|
||||||
|
|
||||||
++buf32;
|
++buf32;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
if (remaining_bytes) {
|
if (remaining_bytes) {
|
||||||
value = 0;
|
value = 0;
|
||||||
memcpy(&value, (u8 *)buf32, remaining_bytes);
|
memcpy(&value, (u8 *)buf32, remaining_bytes);
|
||||||
hid_set_field(report->field[field_index], i,
|
ret = hid_set_field(report->field[field_index], i,
|
||||||
(__force __s32)cpu_to_le32(value));
|
(__force __s32)cpu_to_le32(value));
|
||||||
|
if (ret)
|
||||||
|
goto done_proc;
|
||||||
}
|
}
|
||||||
hid_hw_request(hsdev->hdev, report, HID_REQ_SET_REPORT);
|
hid_hw_request(hsdev->hdev, report, HID_REQ_SET_REPORT);
|
||||||
hid_hw_wait(hsdev->hdev);
|
hid_hw_wait(hsdev->hdev);
|
||||||
|
|
Loading…
Reference in a new issue