mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-21 16:29:59 +00:00
Input: elan_i2c_smbus - cast sizeof to int for comparison
Comparing an int to a size, which is unsigned, causes the int to become unsigned, giving the wrong result. i2c_smbus_read_block_data can return the result of i2c_smbus_xfer, whih can return a negative error code. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ int x; expression e,e1; identifier f; @@ *x = f(...); ... when != x = e1 when != if (x < 0 || ...) { ... return ...; } *x < sizeof(e) // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
This commit is contained in:
parent
384cf4285b
commit
ce1d6f22fa
1 changed files with 1 additions and 1 deletions
|
@ -387,7 +387,7 @@ static int elan_smbus_prepare_fw_update(struct i2c_client *client)
|
|||
len = i2c_smbus_read_block_data(client,
|
||||
ETP_SMBUS_IAP_PASSWORD_READ,
|
||||
val);
|
||||
if (len < sizeof(u16)) {
|
||||
if (len < (int)sizeof(u16)) {
|
||||
error = len < 0 ? len : -EIO;
|
||||
dev_err(dev, "failed to read iap password: %d\n",
|
||||
error);
|
||||
|
|
Loading…
Reference in a new issue