mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-24 17:59:32 +00:00
btrfs: remove redundant null bdev counting during flush submission
There is no extra benefit to count null bdev during the submit loop, as these null devices will be anyway checked during command completion device loop just after the submit loop. We are holding the device_list_mutex, the device->bdev status won't change in between. Signed-off-by: Anand Jain <anand.jain@oracle.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
parent
12b9bf0b94
commit
cea7c8bf77
1 changed files with 2 additions and 5 deletions
|
@ -3564,7 +3564,6 @@ static int barrier_all_devices(struct btrfs_fs_info *info)
|
|||
{
|
||||
struct list_head *head;
|
||||
struct btrfs_device *dev;
|
||||
int errors_send = 0;
|
||||
int errors_wait = 0;
|
||||
int ret;
|
||||
|
||||
|
@ -3573,10 +3572,8 @@ static int barrier_all_devices(struct btrfs_fs_info *info)
|
|||
list_for_each_entry_rcu(dev, head, dev_list) {
|
||||
if (dev->missing)
|
||||
continue;
|
||||
if (!dev->bdev) {
|
||||
errors_send++;
|
||||
if (!dev->bdev)
|
||||
continue;
|
||||
}
|
||||
if (!dev->in_fs_metadata || !dev->writeable)
|
||||
continue;
|
||||
|
||||
|
@ -3602,7 +3599,7 @@ static int barrier_all_devices(struct btrfs_fs_info *info)
|
|||
}
|
||||
}
|
||||
|
||||
if (errors_send || errors_wait) {
|
||||
if (errors_wait) {
|
||||
/*
|
||||
* At some point we need the status of all disks
|
||||
* to arrive at the volume status. So error checking
|
||||
|
|
Loading…
Reference in a new issue