mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-25 11:55:37 +00:00
drm/panel: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert the drm panel drivers from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Douglas Anderson <dianders@chromium.org> Link: https://patchwork.freedesktop.org/patch/msgid/20230507162616.1368908-36-u.kleine-koenig@pengutronix.de
This commit is contained in:
parent
bd296a594e
commit
cef3776d0b
4 changed files with 8 additions and 16 deletions
|
@ -228,15 +228,13 @@ static int panel_lvds_probe(struct platform_device *pdev)
|
|||
return 0;
|
||||
}
|
||||
|
||||
static int panel_lvds_remove(struct platform_device *pdev)
|
||||
static void panel_lvds_remove(struct platform_device *pdev)
|
||||
{
|
||||
struct panel_lvds *lvds = platform_get_drvdata(pdev);
|
||||
|
||||
drm_panel_remove(&lvds->panel);
|
||||
|
||||
drm_panel_disable(&lvds->panel);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static const struct of_device_id panel_lvds_of_table[] = {
|
||||
|
@ -248,7 +246,7 @@ MODULE_DEVICE_TABLE(of, panel_lvds_of_table);
|
|||
|
||||
static struct platform_driver panel_lvds_driver = {
|
||||
.probe = panel_lvds_probe,
|
||||
.remove = panel_lvds_remove,
|
||||
.remove_new = panel_lvds_remove,
|
||||
.driver = {
|
||||
.name = "panel-lvds",
|
||||
.of_match_table = panel_lvds_of_table,
|
||||
|
|
|
@ -278,14 +278,12 @@ static int seiko_panel_probe(struct device *dev,
|
|||
return 0;
|
||||
}
|
||||
|
||||
static int seiko_panel_remove(struct platform_device *pdev)
|
||||
static void seiko_panel_remove(struct platform_device *pdev)
|
||||
{
|
||||
struct seiko_panel *panel = platform_get_drvdata(pdev);
|
||||
|
||||
drm_panel_remove(&panel->base);
|
||||
drm_panel_disable(&panel->base);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static void seiko_panel_shutdown(struct platform_device *pdev)
|
||||
|
@ -347,7 +345,7 @@ static struct platform_driver seiko_panel_platform_driver = {
|
|||
.of_match_table = platform_of_match,
|
||||
},
|
||||
.probe = seiko_panel_platform_probe,
|
||||
.remove = seiko_panel_remove,
|
||||
.remove_new = seiko_panel_remove,
|
||||
.shutdown = seiko_panel_shutdown,
|
||||
};
|
||||
module_platform_driver(seiko_panel_platform_driver);
|
||||
|
|
|
@ -189,15 +189,13 @@ static int ls037v7dw01_probe(struct platform_device *pdev)
|
|||
return 0;
|
||||
}
|
||||
|
||||
static int ls037v7dw01_remove(struct platform_device *pdev)
|
||||
static void ls037v7dw01_remove(struct platform_device *pdev)
|
||||
{
|
||||
struct ls037v7dw01_panel *lcd = platform_get_drvdata(pdev);
|
||||
|
||||
drm_panel_remove(&lcd->panel);
|
||||
drm_panel_disable(&lcd->panel);
|
||||
drm_panel_unprepare(&lcd->panel);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static const struct of_device_id ls037v7dw01_of_match[] = {
|
||||
|
@ -209,7 +207,7 @@ MODULE_DEVICE_TABLE(of, ls037v7dw01_of_match);
|
|||
|
||||
static struct platform_driver ls037v7dw01_driver = {
|
||||
.probe = ls037v7dw01_probe,
|
||||
.remove = ls037v7dw01_remove,
|
||||
.remove_new = ls037v7dw01_remove,
|
||||
.driver = {
|
||||
.name = "panel-sharp-ls037v7dw01",
|
||||
.of_match_table = ls037v7dw01_of_match,
|
||||
|
|
|
@ -4466,11 +4466,9 @@ static int panel_simple_platform_probe(struct platform_device *pdev)
|
|||
return panel_simple_probe(&pdev->dev, id->data);
|
||||
}
|
||||
|
||||
static int panel_simple_platform_remove(struct platform_device *pdev)
|
||||
static void panel_simple_platform_remove(struct platform_device *pdev)
|
||||
{
|
||||
panel_simple_remove(&pdev->dev);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static void panel_simple_platform_shutdown(struct platform_device *pdev)
|
||||
|
@ -4491,7 +4489,7 @@ static struct platform_driver panel_simple_platform_driver = {
|
|||
.pm = &panel_simple_pm_ops,
|
||||
},
|
||||
.probe = panel_simple_platform_probe,
|
||||
.remove = panel_simple_platform_remove,
|
||||
.remove_new = panel_simple_platform_remove,
|
||||
.shutdown = panel_simple_platform_shutdown,
|
||||
};
|
||||
|
||||
|
|
Loading…
Reference in a new issue