mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-21 08:19:28 +00:00
netfilter: ipt_LOG/ip6t_LOG: remove comparison within loop
Remove the comparison within the loop to print the macheader by prepending the colon to all but the first printk. Based on suggestion by Jan Engelhardt <jengelh@medozas.de>. Signed-off-by: Patrick McHardy <kaber@trash.net>
This commit is contained in:
parent
d70a011dbb
commit
cf377eb4ae
2 changed files with 9 additions and 9 deletions
|
@ -411,12 +411,12 @@ ipt_log_packet(u_int8_t pf,
|
|||
skb->mac_header != skb->network_header) {
|
||||
int i;
|
||||
const unsigned char *p = skb_mac_header(skb);
|
||||
for (i = 0; i < skb->dev->hard_header_len; i++,p++)
|
||||
printk("%02x%c", *p,
|
||||
i==skb->dev->hard_header_len - 1
|
||||
? ' ':':');
|
||||
} else
|
||||
printk(" ");
|
||||
|
||||
printk("%02x", *p++);
|
||||
for (i = 1; i < skb->dev->hard_header_len; i++, p++)
|
||||
printk(":%02x", *p);
|
||||
}
|
||||
printk(" ");
|
||||
}
|
||||
|
||||
dump_packet(loginfo, skb, 0);
|
||||
|
|
|
@ -414,9 +414,9 @@ ip6t_log_packet(u_int8_t pf,
|
|||
p = NULL;
|
||||
|
||||
if (p != NULL) {
|
||||
for (i = 0; i < len; i++)
|
||||
printk("%02x%s", p[i],
|
||||
i == len - 1 ? "" : ":");
|
||||
printk("%02x", *p++);
|
||||
for (i = 1; i < len; i++)
|
||||
printk(":%02x", p[i]);
|
||||
}
|
||||
printk(" ");
|
||||
|
||||
|
|
Loading…
Reference in a new issue