mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-27 04:47:05 +00:00
amd/pds_core: core: No need for Null pointer check before kfree
kfree()/vfree() internally perform NULL check on the pointer handed to it and take no action if it indeed is NULL. Hence there is no need for a pre-check of the memory pointer before handing it to kfree()/vfree(). Issue reported by ifnullfree.cocci Coccinelle semantic patch script. Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com> Reviewed-by: Shannon Nelson <shannon.nelson@amd.com> Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
61450abfc9
commit
d0110443cf
1 changed files with 2 additions and 5 deletions
|
@ -152,11 +152,8 @@ void pdsc_qcq_free(struct pdsc *pdsc, struct pdsc_qcq *qcq)
|
|||
dma_free_coherent(dev, qcq->cq_size,
|
||||
qcq->cq_base, qcq->cq_base_pa);
|
||||
|
||||
if (qcq->cq.info)
|
||||
vfree(qcq->cq.info);
|
||||
|
||||
if (qcq->q.info)
|
||||
vfree(qcq->q.info);
|
||||
vfree(qcq->cq.info);
|
||||
vfree(qcq->q.info);
|
||||
|
||||
memset(qcq, 0, sizeof(*qcq));
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue