mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-30 22:26:55 +00:00
[SCSI] sg: handle class_device_create failure properly
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> Acked-by: Douglas Gilbert <dougg@torque.net> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
This commit is contained in:
parent
a24484f281
commit
d07e03610c
1 changed files with 7 additions and 4 deletions
|
@ -1434,11 +1434,14 @@ sg_add(struct class_device *cl_dev, struct class_interface *cl_intf)
|
|||
MKDEV(SCSI_GENERIC_MAJOR, sdp->index),
|
||||
cl_dev->dev, "%s",
|
||||
disk->disk_name);
|
||||
if (IS_ERR(sg_class_member))
|
||||
printk(KERN_WARNING "sg_add: "
|
||||
"class_device_create failed\n");
|
||||
if (IS_ERR(sg_class_member)) {
|
||||
printk(KERN_ERR "sg_add: "
|
||||
"class_device_create failed\n");
|
||||
error = PTR_ERR(sg_class_member);
|
||||
goto cdev_add_err;
|
||||
}
|
||||
class_set_devdata(sg_class_member, sdp);
|
||||
error = sysfs_create_link(&scsidp->sdev_gendev.kobj,
|
||||
error = sysfs_create_link(&scsidp->sdev_gendev.kobj,
|
||||
&sg_class_member->kobj, "generic");
|
||||
if (error)
|
||||
printk(KERN_ERR "sg_add: unable to make symlink "
|
||||
|
|
Loading…
Reference in a new issue