mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-29 13:53:33 +00:00
powerpc/powernv/opal-dump : Use IRQ_HANDLED instead of numbers in interrupt handler
[ Upstream commitb29336c0e1
] Fixes:8034f715f
("powernv/opal-dump: Convert to irq domain") Converts all the return explicit number to a more proper IRQ_HANDLED, which looks proper incase of interrupt handler returning case. Here, It also removes error message like "nobody cared" which was getting unveiled while returning -1 or 0 from handler. Signed-off-by: Mukesh Ojha <mukesh02@linux.vnet.ibm.com> Reviewed-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
6d6d017a6d
commit
d0b6efebed
1 changed files with 3 additions and 6 deletions
|
@ -385,13 +385,12 @@ static irqreturn_t process_dump(int irq, void *data)
|
||||||
{
|
{
|
||||||
int rc;
|
int rc;
|
||||||
uint32_t dump_id, dump_size, dump_type;
|
uint32_t dump_id, dump_size, dump_type;
|
||||||
struct dump_obj *dump;
|
|
||||||
char name[22];
|
char name[22];
|
||||||
struct kobject *kobj;
|
struct kobject *kobj;
|
||||||
|
|
||||||
rc = dump_read_info(&dump_id, &dump_size, &dump_type);
|
rc = dump_read_info(&dump_id, &dump_size, &dump_type);
|
||||||
if (rc != OPAL_SUCCESS)
|
if (rc != OPAL_SUCCESS)
|
||||||
return rc;
|
return IRQ_HANDLED;
|
||||||
|
|
||||||
sprintf(name, "0x%x-0x%x", dump_type, dump_id);
|
sprintf(name, "0x%x-0x%x", dump_type, dump_id);
|
||||||
|
|
||||||
|
@ -403,12 +402,10 @@ static irqreturn_t process_dump(int irq, void *data)
|
||||||
if (kobj) {
|
if (kobj) {
|
||||||
/* Drop reference added by kset_find_obj() */
|
/* Drop reference added by kset_find_obj() */
|
||||||
kobject_put(kobj);
|
kobject_put(kobj);
|
||||||
return 0;
|
return IRQ_HANDLED;
|
||||||
}
|
}
|
||||||
|
|
||||||
dump = create_dump_obj(dump_id, dump_size, dump_type);
|
create_dump_obj(dump_id, dump_size, dump_type);
|
||||||
if (!dump)
|
|
||||||
return -1;
|
|
||||||
|
|
||||||
return IRQ_HANDLED;
|
return IRQ_HANDLED;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue