mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-14 04:26:45 +00:00
net: hns: set correct return value
The function of_parse_phandle() returns a NULL pointer if it cannot resolve a phandle property to a device_node pointer. In function hns_nic_dev_probe(), its return value is passed to PTR_ERR to extract the error code. However, in this case, the extracted error code will always be zero, which is unexpected. Signed-off-by: Pan Bian <bianpan2016@163.com> Reviewed-by: Tobias Klauser <tklauser@distanz.ch> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
7db8874abd
commit
d2083d0e92
1 changed files with 2 additions and 2 deletions
|
@ -2369,8 +2369,8 @@ static int hns_nic_dev_probe(struct platform_device *pdev)
|
||||||
priv->enet_ver = AE_VERSION_2;
|
priv->enet_ver = AE_VERSION_2;
|
||||||
|
|
||||||
ae_node = of_parse_phandle(dev->of_node, "ae-handle", 0);
|
ae_node = of_parse_phandle(dev->of_node, "ae-handle", 0);
|
||||||
if (IS_ERR_OR_NULL(ae_node)) {
|
if (!ae_node) {
|
||||||
ret = PTR_ERR(ae_node);
|
ret = -ENODEV;
|
||||||
dev_err(dev, "not find ae-handle\n");
|
dev_err(dev, "not find ae-handle\n");
|
||||||
goto out_read_prop_fail;
|
goto out_read_prop_fail;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue