mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 17:30:02 +00:00
tehuti: return -EFAULT on copy_to_user errors
copy_to_user() returns the number of bytes remaining but we want to return a negative error code here. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
60a5711db6
commit
d233807018
1 changed files with 2 additions and 2 deletions
|
@ -646,7 +646,7 @@ static int bdx_ioctl_priv(struct net_device *ndev, struct ifreq *ifr, int cmd)
|
|||
error = copy_from_user(data, ifr->ifr_data, sizeof(data));
|
||||
if (error) {
|
||||
pr_err("cant copy from user\n");
|
||||
RET(error);
|
||||
RET(-EFAULT);
|
||||
}
|
||||
DBG("%d 0x%x 0x%x\n", data[0], data[1], data[2]);
|
||||
}
|
||||
|
@ -665,7 +665,7 @@ static int bdx_ioctl_priv(struct net_device *ndev, struct ifreq *ifr, int cmd)
|
|||
data[2]);
|
||||
error = copy_to_user(ifr->ifr_data, data, sizeof(data));
|
||||
if (error)
|
||||
RET(error);
|
||||
RET(-EFAULT);
|
||||
break;
|
||||
|
||||
case BDX_OP_WRITE:
|
||||
|
|
Loading…
Reference in a new issue