mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-30 22:26:55 +00:00
staging: greybus: audio: replace safe list iteration
No entry is being removed from the list when iterating the widget list in gbaudio_dapm_free_controls() so there's no need to use list_for_each_entry_safe(). Signed-off-by: Johan Hovold <johan@kernel.org> Link: https://lore.kernel.org/r/20220610075347.18917-1-johan@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
991ebc7303
commit
d2b47721a1
1 changed files with 2 additions and 3 deletions
|
@ -115,7 +115,7 @@ int gbaudio_dapm_free_controls(struct snd_soc_dapm_context *dapm,
|
||||||
int num)
|
int num)
|
||||||
{
|
{
|
||||||
int i;
|
int i;
|
||||||
struct snd_soc_dapm_widget *w, *next_w, *tmp_w;
|
struct snd_soc_dapm_widget *w, *tmp_w;
|
||||||
#ifdef CONFIG_DEBUG_FS
|
#ifdef CONFIG_DEBUG_FS
|
||||||
struct dentry *parent = dapm->debugfs_dapm;
|
struct dentry *parent = dapm->debugfs_dapm;
|
||||||
struct dentry *debugfs_w = NULL;
|
struct dentry *debugfs_w = NULL;
|
||||||
|
@ -125,8 +125,7 @@ int gbaudio_dapm_free_controls(struct snd_soc_dapm_context *dapm,
|
||||||
for (i = 0; i < num; i++) {
|
for (i = 0; i < num; i++) {
|
||||||
/* below logic can be optimized to identify widget pointer */
|
/* below logic can be optimized to identify widget pointer */
|
||||||
w = NULL;
|
w = NULL;
|
||||||
list_for_each_entry_safe(tmp_w, next_w, &dapm->card->widgets,
|
list_for_each_entry(tmp_w, &dapm->card->widgets, list) {
|
||||||
list) {
|
|
||||||
if (tmp_w->dapm == dapm &&
|
if (tmp_w->dapm == dapm &&
|
||||||
!strcmp(tmp_w->name, widget->name)) {
|
!strcmp(tmp_w->name, widget->name)) {
|
||||||
w = tmp_w;
|
w = tmp_w;
|
||||||
|
|
Loading…
Reference in a new issue