mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-07 03:18:31 +00:00
tcp: Fix a data-race around sysctl_tcp_retrans_collapse.
[ Upstream commit1a63cb91f0
] While reading sysctl_tcp_retrans_collapse, it can be changed concurrently. Thus, we need to add READ_ONCE() to its reader. Fixes:1da177e4c3
("Linux-2.6.12-rc2") Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
68b6f95067
commit
d316488be1
1 changed files with 1 additions and 1 deletions
|
@ -3103,7 +3103,7 @@ static void tcp_retrans_try_collapse(struct sock *sk, struct sk_buff *to,
|
||||||
struct sk_buff *skb = to, *tmp;
|
struct sk_buff *skb = to, *tmp;
|
||||||
bool first = true;
|
bool first = true;
|
||||||
|
|
||||||
if (!sock_net(sk)->ipv4.sysctl_tcp_retrans_collapse)
|
if (!READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_retrans_collapse))
|
||||||
return;
|
return;
|
||||||
if (TCP_SKB_CB(skb)->tcp_flags & TCPHDR_SYN)
|
if (TCP_SKB_CB(skb)->tcp_flags & TCPHDR_SYN)
|
||||||
return;
|
return;
|
||||||
|
|
Loading…
Reference in a new issue