mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-21 16:29:59 +00:00
knfsd: fix broken length check in nfs4idmap.c
Obviously at some point we thought "error" represented the length when positive. This appears to be a long-standing typo. Thanks to Prasad Potluri <pvp@us.ibm.com> for finding the problem and proposing an earlier version of this patch. Cc: Steve French <smfltc@us.ibm.com> Cc: Prasad V Potluri <pvp@us.ibm.com> Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
This commit is contained in:
parent
aefa89d178
commit
d4395e03fe
1 changed files with 3 additions and 6 deletions
|
@ -255,13 +255,10 @@ idtoname_parse(struct cache_detail *cd, char *buf, int buflen)
|
|||
goto out;
|
||||
if (len == 0)
|
||||
set_bit(CACHE_NEGATIVE, &ent.h.flags);
|
||||
else {
|
||||
if (error >= IDMAP_NAMESZ) {
|
||||
error = -EINVAL;
|
||||
goto out;
|
||||
}
|
||||
else if (len >= IDMAP_NAMESZ)
|
||||
goto out;
|
||||
else
|
||||
memcpy(ent.name, buf1, sizeof(ent.name));
|
||||
}
|
||||
error = -ENOMEM;
|
||||
res = idtoname_update(&ent, res);
|
||||
if (res == NULL)
|
||||
|
|
Loading…
Reference in a new issue