mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-05 18:39:59 +00:00
staging: rtl8192u: fix a dubious looking mask before a shift
[ Upstream commitc4283950a9
] Currently the masking of ret with 0xff and followed by a right shift of 8 bits always leaves a zero result. It appears the mask of 0xff is incorrect and should be 0xff00, but I don't have the hardware to test this. Fix this to mask the upper 8 bits before shifting. [ Not tested ] Addresses-Coverity: ("Operands don't affect result") Fixes:8fc8598e61
("Staging: Added Realtek rtl8192u driver to staging") Signed-off-by: Colin Ian King <colin.king@canonical.com> Link: https://lore.kernel.org/r/20200716154720.1710252-1-colin.king@canonical.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
172f9611b7
commit
d548f0f566
1 changed files with 1 additions and 1 deletions
|
@ -2519,7 +2519,7 @@ static int rtl8192_read_eeprom_info(struct net_device *dev)
|
|||
ret = eprom_read(dev, (EEPROM_TxPwIndex_CCK >> 1));
|
||||
if (ret < 0)
|
||||
return ret;
|
||||
priv->EEPROMTxPowerLevelCCK = ((u16)ret & 0xff) >> 8;
|
||||
priv->EEPROMTxPowerLevelCCK = ((u16)ret & 0xff00) >> 8;
|
||||
} else
|
||||
priv->EEPROMTxPowerLevelCCK = 0x10;
|
||||
RT_TRACE(COMP_EPROM, "CCK Tx Power Levl: 0x%02x\n", priv->EEPROMTxPowerLevelCCK);
|
||||
|
|
Loading…
Reference in a new issue