drm/bridge: cdns-dsi: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> Link: https://patchwork.freedesktop.org/patch/msgid/20230318190804.234610-3-u.kleine-koenig@pengutronix.de
This commit is contained in:
parent
b704eeae31
commit
d5701d8f52
|
@ -1278,7 +1278,7 @@ err_disable_pclk:
|
|||
return ret;
|
||||
}
|
||||
|
||||
static int cdns_dsi_drm_remove(struct platform_device *pdev)
|
||||
static void cdns_dsi_drm_remove(struct platform_device *pdev)
|
||||
{
|
||||
struct cdns_dsi *dsi = platform_get_drvdata(pdev);
|
||||
|
||||
|
@ -1288,8 +1288,6 @@ static int cdns_dsi_drm_remove(struct platform_device *pdev)
|
|||
dsi->platform_ops->deinit(dsi);
|
||||
|
||||
pm_runtime_disable(&pdev->dev);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static const struct of_device_id cdns_dsi_of_match[] = {
|
||||
|
@ -1303,7 +1301,7 @@ MODULE_DEVICE_TABLE(of, cdns_dsi_of_match);
|
|||
|
||||
static struct platform_driver cdns_dsi_platform_driver = {
|
||||
.probe = cdns_dsi_drm_probe,
|
||||
.remove = cdns_dsi_drm_remove,
|
||||
.remove_new = cdns_dsi_drm_remove,
|
||||
.driver = {
|
||||
.name = "cdns-dsi",
|
||||
.of_match_table = cdns_dsi_of_match,
|
||||
|
|
Loading…
Reference in New Issue