mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-30 14:19:16 +00:00
samples: bpf: fix: seg fault with NULL pointer arg
When NULL pointer accidentally passed to write_kprobe_events, due to strlen(NULL), segmentation fault happens. Changed code returns -1 to deal with this situation. Bug issued with Smatch, static analysis. Signed-off-by: Daniel T. Lee <danieltimlee@gmail.com> Acked-by: Song Liu <songliubraving@fb.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
This commit is contained in:
parent
90b1023f68
commit
d59dd69d55
1 changed files with 3 additions and 1 deletions
|
@ -58,7 +58,9 @@ static int write_kprobe_events(const char *val)
|
||||||
{
|
{
|
||||||
int fd, ret, flags;
|
int fd, ret, flags;
|
||||||
|
|
||||||
if ((val != NULL) && (val[0] == '\0'))
|
if (val == NULL)
|
||||||
|
return -1;
|
||||||
|
else if (val[0] == '\0')
|
||||||
flags = O_WRONLY | O_TRUNC;
|
flags = O_WRONLY | O_TRUNC;
|
||||||
else
|
else
|
||||||
flags = O_WRONLY | O_APPEND;
|
flags = O_WRONLY | O_APPEND;
|
||||||
|
|
Loading…
Reference in a new issue