mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-12 05:48:40 +00:00
[PATCH] SKB leak in drivers/isdn/i4l/isdn_x25iface.c
Coverity spotted this leak (id #613), when we are not configured, we return without freeing the allocated skb. Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de> Acked-by: Karsten Keil <kkeil@suse.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
parent
9dc3885dfb
commit
d81931d9a2
1 changed files with 3 additions and 1 deletions
|
@ -208,7 +208,7 @@ static int isdn_x25iface_receive(struct concap_proto *cprot, struct sk_buff *skb
|
|||
*/
|
||||
static int isdn_x25iface_connect_ind(struct concap_proto *cprot)
|
||||
{
|
||||
struct sk_buff * skb = dev_alloc_skb(1);
|
||||
struct sk_buff * skb;
|
||||
enum wan_states *state_p
|
||||
= &( ( (ix25_pdata_t*) (cprot->proto_data) ) -> state);
|
||||
IX25DEBUG( "isdn_x25iface_connect_ind %s \n"
|
||||
|
@ -220,6 +220,8 @@ static int isdn_x25iface_connect_ind(struct concap_proto *cprot)
|
|||
return -1;
|
||||
}
|
||||
*state_p = WAN_CONNECTED;
|
||||
|
||||
skb = dev_alloc_skb(1);
|
||||
if( skb ){
|
||||
*( skb_put(skb, 1) ) = 0x01;
|
||||
skb->protocol = x25_type_trans(skb, cprot->net_dev);
|
||||
|
|
Loading…
Reference in a new issue