mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-08-29 04:09:39 +00:00
Code Issues Releases Wiki Activity

platform/x86: surface3_power: Fix always true condition in mshw0011_space_handler()

Browse source 
smatch warnings:
.../surface3_power.c:417 mshw0011_space_handler() warn: always true condition '(ret >= 0) => +(0-u32max >= 0)'

Refactor error handling returned by mshw0011_adp_psr() to avoid always
true condition.

Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
This commit is contained in:
Andy Shevchenko 2020-03-30 13:26:50 +03:00
parent ba308bd090
commit d878bdfba8
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
drivers/platform/x86/surface3_power.c
View file

@ -402,12 +402,14 @@ mshw0011_space_handler(u32 function, acpi_physical_address command,
if (gsb->cmd.arg0 == MSHW0011_CMD_DEST_ADP1 &&
gsb->cmd.arg1 == MSHW0011_CMD_ADP1_PSR) {
ret = mshw0011_adp_psr(cdata);
if (ret >= 0) {
status = ret;
ret = 0;
status = mshw0011_adp_psr(cdata);
if (status >= 0) {
ret = AE_OK;
goto out;
} else {
ret = AE_ERROR;
goto err;
}
goto out;
}
if (gsb->cmd.arg0 != MSHW0011_CMD_DEST_BAT0) {