mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-06 08:46:46 +00:00
icmp: Fix a data-race around sysctl_icmp_ignore_bogus_error_responses.
[ Upstream commitb04f9b7e85
] While reading sysctl_icmp_ignore_bogus_error_responses, it can be changed concurrently. Thus, we need to add READ_ONCE() to its reader. Fixes:1da177e4c3
("Linux-2.6.12-rc2") Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
48fda9af1d
commit
d9a9433f81
2 changed files with 3 additions and 1 deletions
|
@ -930,7 +930,7 @@ static bool icmp_unreach(struct sk_buff *skb)
|
|||
* get the other vendor to fix their kit.
|
||||
*/
|
||||
|
||||
if (!net->ipv4.sysctl_icmp_ignore_bogus_error_responses &&
|
||||
if (!READ_ONCE(net->ipv4.sysctl_icmp_ignore_bogus_error_responses) &&
|
||||
inet_addr_type_dev_table(net, skb->dev, iph->daddr) == RTN_BROADCAST) {
|
||||
net_warn_ratelimited("%pI4 sent an invalid ICMP type %u, code %u error to a broadcast: %pI4 on %s\n",
|
||||
&ip_hdr(skb)->saddr,
|
||||
|
|
|
@ -630,6 +630,8 @@ static struct ctl_table ipv4_net_table[] = {
|
|||
.maxlen = sizeof(u8),
|
||||
.mode = 0644,
|
||||
.proc_handler = proc_dou8vec_minmax,
|
||||
.extra1 = SYSCTL_ZERO,
|
||||
.extra2 = SYSCTL_ONE
|
||||
},
|
||||
{
|
||||
.procname = "icmp_errors_use_inbound_ifaddr",
|
||||
|
|
Loading…
Reference in a new issue