mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-10-02 07:04:24 +00:00
Code Issues Releases Wiki Activity

scsi: ufs: Replace sprintf and snprintf with sysfs_emit

Browse source 
sprintf and snprintf may cause output defect in sysfs content, it is better
to use new added sysfs_emit function which knows the size of the temporary
buffer.

Link: https://lore.kernel.org/r/20210106211541.23039-1-huobean@gmail.com
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
Reviewed-by: Can Guo <cang@codeaurora.org>
Signed-off-by: Bean Huo <beanhuo@micron.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Bean Huo 2021-01-06 22:15:41 +01:00 committed by Martin K. Petersen
parent aaac0ea983
commit d9edeb8b47
1 changed files with 15 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
drivers/scsi/ufs/ufs-sysfs.c
View file

@ -67,7 +67,7 @@ static ssize_t rpm_lvl_show(struct device *dev,
{ {
struct ufs_hba *hba = dev_get_drvdata(dev); struct ufs_hba *hba = dev_get_drvdata(dev);
return sprintf(buf, "%d\n", hba->rpm_lvl); return sysfs_emit(buf, "%d\n", hba->rpm_lvl);
} }
static ssize_t rpm_lvl_store(struct device *dev, static ssize_t rpm_lvl_store(struct device *dev,
@ -81,7 +81,7 @@ static ssize_t rpm_target_dev_state_show(struct device *dev,
{ {
struct ufs_hba *hba = dev_get_drvdata(dev); struct ufs_hba *hba = dev_get_drvdata(dev);
return sprintf(buf, "%s\n", ufschd_ufs_dev_pwr_mode_to_string( return sysfs_emit(buf, "%s\n", ufschd_ufs_dev_pwr_mode_to_string(
ufs_pm_lvl_states[hba->rpm_lvl].dev_state)); ufs_pm_lvl_states[hba->rpm_lvl].dev_state));
} }
@ -90,7 +90,7 @@ static ssize_t rpm_target_link_state_show(struct device *dev,
{ {
struct ufs_hba *hba = dev_get_drvdata(dev); struct ufs_hba *hba = dev_get_drvdata(dev);
return sprintf(buf, "%s\n", ufschd_uic_link_state_to_string( return sysfs_emit(buf, "%s\n", ufschd_uic_link_state_to_string(
ufs_pm_lvl_states[hba->rpm_lvl].link_state)); ufs_pm_lvl_states[hba->rpm_lvl].link_state));
} }
@ -99,7 +99,7 @@ static ssize_t spm_lvl_show(struct device *dev,
{ {
struct ufs_hba *hba = dev_get_drvdata(dev); struct ufs_hba *hba = dev_get_drvdata(dev);
return sprintf(buf, "%d\n", hba->spm_lvl); return sysfs_emit(buf, "%d\n", hba->spm_lvl);
} }
static ssize_t spm_lvl_store(struct device *dev, static ssize_t spm_lvl_store(struct device *dev,
@ -113,7 +113,7 @@ static ssize_t spm_target_dev_state_show(struct device *dev,
{ {
struct ufs_hba *hba = dev_get_drvdata(dev); struct ufs_hba *hba = dev_get_drvdata(dev);
return sprintf(buf, "%s\n", ufschd_ufs_dev_pwr_mode_to_string( return sysfs_emit(buf, "%s\n", ufschd_ufs_dev_pwr_mode_to_string(
ufs_pm_lvl_states[hba->spm_lvl].dev_state)); ufs_pm_lvl_states[hba->spm_lvl].dev_state));
} }
@ -122,7 +122,7 @@ static ssize_t spm_target_link_state_show(struct device *dev,
{ {
struct ufs_hba *hba = dev_get_drvdata(dev); struct ufs_hba *hba = dev_get_drvdata(dev);
return sprintf(buf, "%s\n", ufschd_uic_link_state_to_string( return sysfs_emit(buf, "%s\n", ufschd_uic_link_state_to_string(
ufs_pm_lvl_states[hba->spm_lvl].link_state)); ufs_pm_lvl_states[hba->spm_lvl].link_state));
} }
@ -165,7 +165,7 @@ static ssize_t auto_hibern8_show(struct device *dev,
ufshcd_release(hba); ufshcd_release(hba);
pm_runtime_put_sync(hba->dev); pm_runtime_put_sync(hba->dev);
return scnprintf(buf, PAGE_SIZE, "%d\n", ufshcd_ahit_to_us(ahit)); return sysfs_emit(buf, "%d\n", ufshcd_ahit_to_us(ahit));
} }
static ssize_t auto_hibern8_store(struct device *dev, static ssize_t auto_hibern8_store(struct device *dev,
@ -233,18 +233,18 @@ static ssize_t ufs_sysfs_read_desc_param(struct ufs_hba *hba,
return -EINVAL; return -EINVAL;
switch (param_size) { switch (param_size) {
case 1: case 1:
ret = sprintf(sysfs_buf, "0x%02X\n", *desc_buf); ret = sysfs_emit(sysfs_buf, "0x%02X\n", *desc_buf);
break; break;
case 2: case 2:
ret = sprintf(sysfs_buf, "0x%04X\n", ret = sysfs_emit(sysfs_buf, "0x%04X\n",
get_unaligned_be16(desc_buf)); get_unaligned_be16(desc_buf));
break; break;
case 4: case 4:
ret = sprintf(sysfs_buf, "0x%08X\n", ret = sysfs_emit(sysfs_buf, "0x%08X\n",
get_unaligned_be32(desc_buf)); get_unaligned_be32(desc_buf));
break; break;
case 8: case 8:
ret = sprintf(sysfs_buf, "0x%016llX\n", ret = sysfs_emit(sysfs_buf, "0x%016llX\n",
get_unaligned_be64(desc_buf)); get_unaligned_be64(desc_buf));
break; break;
} }
@ -609,7 +609,7 @@ static ssize_t _name##_show(struct device *dev, \
SD_ASCII_STD); \ SD_ASCII_STD); \
if (ret < 0) \ if (ret < 0) \
goto out; \ goto out; \
ret = snprintf(buf, PAGE_SIZE, "%s\n", desc_buf); \ ret = sysfs_emit(buf, "%s\n", desc_buf); \
out: \ out: \
pm_runtime_put_sync(hba->dev); \ pm_runtime_put_sync(hba->dev); \
kfree(desc_buf); \ kfree(desc_buf); \
@ -659,7 +659,7 @@ static ssize_t _name##_show(struct device *dev, \
pm_runtime_put_sync(hba->dev); \ pm_runtime_put_sync(hba->dev); \
if (ret) \ if (ret) \
return -EINVAL; \ return -EINVAL; \
return sprintf(buf, "%s\n", flag ? "true" : "false"); \ return sysfs_emit(buf, "%s\n", flag ? "true" : "false"); \
} \ } \
static DEVICE_ATTR_RO(_name) static DEVICE_ATTR_RO(_name)
@ -717,7 +717,7 @@ static ssize_t _name##_show(struct device *dev, \
pm_runtime_put_sync(hba->dev); \ pm_runtime_put_sync(hba->dev); \
if (ret) \ if (ret) \
return -EINVAL; \ return -EINVAL; \
return sprintf(buf, "0x%08X\n", value); \ return sysfs_emit(buf, "0x%08X\n", value); \
} \ } \
static DEVICE_ATTR_RO(_name) static DEVICE_ATTR_RO(_name)
@ -856,7 +856,7 @@ static ssize_t dyn_cap_needed_attribute_show(struct device *dev,
pm_runtime_put_sync(hba->dev); pm_runtime_put_sync(hba->dev);
if (ret) if (ret)
return -EINVAL; return -EINVAL;
return sprintf(buf, "0x%08X\n", value); return sysfs_emit(buf, "0x%08X\n", value);
} }
static DEVICE_ATTR_RO(dyn_cap_needed_attribute); static DEVICE_ATTR_RO(dyn_cap_needed_attribute);