mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-28 07:13:34 +00:00
fs/writeback: bail out if there is no more inodes for IO and queued once
[ Upstream commit d92109891f
]
For case there is no more inodes for IO in io list from last wb_writeback,
We may bail out early even there is inode in dirty list should be written
back. Only bail out when we queued once to avoid missing dirtied inode.
This is from code reading...
Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Link: https://lore.kernel.org/r/20240228091958.288260-3-shikemeng@huaweicloud.com
Reviewed-by: Jan Kara <jack@suse.cz>
[brauner@kernel.org: fold in memory corruption fix from Jan in [1]]
Link: https://lore.kernel.org/r/20240405132346.bid7gibby3lxxhez@quack3 [1]
Signed-off-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
9c5a72fbc9
commit
db044fa740
1 changed files with 5 additions and 2 deletions
|
@ -2069,6 +2069,7 @@ static long wb_writeback(struct bdi_writeback *wb,
|
|||
struct inode *inode;
|
||||
long progress;
|
||||
struct blk_plug plug;
|
||||
bool queued = false;
|
||||
|
||||
blk_start_plug(&plug);
|
||||
for (;;) {
|
||||
|
@ -2111,8 +2112,10 @@ static long wb_writeback(struct bdi_writeback *wb,
|
|||
dirtied_before = jiffies;
|
||||
|
||||
trace_writeback_start(wb, work);
|
||||
if (list_empty(&wb->b_io))
|
||||
if (list_empty(&wb->b_io)) {
|
||||
queue_io(wb, work, dirtied_before);
|
||||
queued = true;
|
||||
}
|
||||
if (work->sb)
|
||||
progress = writeback_sb_inodes(work->sb, wb, work);
|
||||
else
|
||||
|
@ -2127,7 +2130,7 @@ static long wb_writeback(struct bdi_writeback *wb,
|
|||
* mean the overall work is done. So we keep looping as long
|
||||
* as made some progress on cleaning pages or inodes.
|
||||
*/
|
||||
if (progress) {
|
||||
if (progress || !queued) {
|
||||
spin_unlock(&wb->list_lock);
|
||||
continue;
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue