mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-27 19:29:37 +00:00
fix integer overflow warning in i2o_block
drivers/message/i2o/i2o_block.c: In function 'i2o_block_transfer': drivers/message/i2o/i2o_block.c:837: warning: integer overflow in expression msg->u.head[1] = cpu_to_le32(I2O_CMD_PRIVATE << 24 | HOST_TID << 12 | tid); and I2O_CMD_PRIVATE is defined as 0xFF. This gets "0xFF0100 | tid" and fits into 32-bit unsigned but not into 32-bit signed integer properly. Target value is defined as u32 so the claculation does not fit during computation. Change local variable tid to u32 so the whole expression is of u32 type and fits well into u32 result. Signed-off-by: Meelis Roos <mroos@linux.ee> Cc: "Salyzyn, Mark" <mark_salyzyn@adaptec.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
parent
ad4a5bb885
commit
db7526f925
1 changed files with 1 additions and 1 deletions
|
@ -744,7 +744,7 @@ static int i2o_block_transfer(struct request *req)
|
|||
{
|
||||
struct i2o_block_device *dev = req->rq_disk->private_data;
|
||||
struct i2o_controller *c;
|
||||
int tid = dev->i2o_dev->lct_data.tid;
|
||||
u32 tid = dev->i2o_dev->lct_data.tid;
|
||||
struct i2o_message *msg;
|
||||
u32 *mptr;
|
||||
struct i2o_block_request *ireq = req->special;
|
||||
|
|
Loading…
Reference in a new issue