mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-08-23 17:30:02 +00:00
Code Issues Releases Wiki Activity

iscsi-target: Do not generate REJECTs for zero-length DataOUT

Browse source 
This patch changes iscsit_check_dataout_hdr() to no longer generate
REJECTs for zero-length DataOUTs, and instead simply ignore these
requests.

This follows RFC-3720, Section 10.7.7.  DataSegmentLength

  "This is the data payload length of a SCSI Data-In or SCSI Data-Out PDU.
   The sending of 0 length data segments should be avoided, but initiators
   and targets MUST be able to properly receive 0 length data segments."

Reported-by: Santosh Kulkarni <santosh.kulkarni@calsoftinc.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
This commit is contained in:
Nicholas Bellinger 2013-11-06 20:55:39 -08:00
parent 95b60f0788
commit dbcbc95cd8
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
drivers/target/iscsi/iscsi_target.c
View file

@ -1249,9 +1249,8 @@ iscsit_check_dataout_hdr(struct iscsi_conn *conn, unsigned char *buf,
int rc; int rc;
if (!payload_length) { if (!payload_length) {
pr_err("DataOUT payload is ZERO, protocol error.\n"); pr_warn("DataOUT payload is ZERO, ignoring.\n");
return iscsit_add_reject(conn, ISCSI_REASON_PROTOCOL_ERROR, return 0;
buf);
} }
/* iSCSI write */ /* iSCSI write */
@ -1481,7 +1480,7 @@ EXPORT_SYMBOL(iscsit_check_dataout_payload);
static int iscsit_handle_data_out(struct iscsi_conn *conn, unsigned char *buf) static int iscsit_handle_data_out(struct iscsi_conn *conn, unsigned char *buf)
{ {
struct iscsi_cmd *cmd; struct iscsi_cmd *cmd = NULL;
struct iscsi_data *hdr = (struct iscsi_data *)buf; struct iscsi_data *hdr = (struct iscsi_data *)buf;
int rc; int rc;
bool data_crc_failed = false; bool data_crc_failed = false;