mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-10-03 23:58:05 +00:00
Code Issues Releases Wiki Activity

Documentation: configfs examples crash fix

Browse source 
When configfs_register_subsystem() fails, we unregister too many
subsystems in configfs_example_init.  Decrement i by one to not unregister
non-registered subsystem.

[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Joel Becker <joel.becker@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Jiri Slaby 2011-05-26 16:25:17 -07:00 committed by Linus Torvalds
parent 02d54f0926
commit dcb3a08e69
2 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Documentation/filesystems/configfs/configfs_example_explicit.c
View file

@ -464,9 +464,8 @@ static int __init configfs_example_init(void)
return 0;
out_unregister:
for (; i >= 0; i--) {
for (i--; i >= 0; i--)
configfs_unregister_subsystem(example_subsys[i]);
}
return ret;
}
@ -475,9 +474,8 @@ static void __exit configfs_example_exit(void)
{
int i;
for (i = 0; example_subsys[i]; i++) {
for (i = 0; example_subsys[i]; i++)
configfs_unregister_subsystem(example_subsys[i]);
}
}
module_init(configfs_example_init);

6
Documentation/filesystems/configfs/configfs_example_macros.c
View file

@ -427,9 +427,8 @@ static int __init configfs_example_init(void)
return 0;
out_unregister:
for (; i >= 0; i--) {
for (i--; i >= 0; i--)
configfs_unregister_subsystem(example_subsys[i]);
}
return ret;
}
@ -438,9 +437,8 @@ static void __exit configfs_example_exit(void)
{
int i;
for (i = 0; example_subsys[i]; i++) {
for (i = 0; example_subsys[i]; i++)
configfs_unregister_subsystem(example_subsys[i]);
}
}
module_init(configfs_example_init);