mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-29 22:02:02 +00:00
serial: mxs-auart: Fix out-of-bounds access through serial port index
The auart_port[] array is indexed using a value derived from the
"serialN" alias in DT, or from platform data, which may lead to an
out-of-bounds access.
Fix this by adding a range check.
Fixes: 1ea6607d4c
("serial: mxs-auart: Allow device tree probing")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
5673444821
commit
dd345a31bf
1 changed files with 4 additions and 0 deletions
|
@ -1663,6 +1663,10 @@ static int mxs_auart_probe(struct platform_device *pdev)
|
||||||
s->port.line = pdev->id < 0 ? 0 : pdev->id;
|
s->port.line = pdev->id < 0 ? 0 : pdev->id;
|
||||||
else if (ret < 0)
|
else if (ret < 0)
|
||||||
return ret;
|
return ret;
|
||||||
|
if (s->port.line >= ARRAY_SIZE(auart_port)) {
|
||||||
|
dev_err(&pdev->dev, "serial%d out of range\n", s->port.line);
|
||||||
|
return -EINVAL;
|
||||||
|
}
|
||||||
|
|
||||||
if (of_id) {
|
if (of_id) {
|
||||||
pdev->id_entry = of_id->data;
|
pdev->id_entry = of_id->data;
|
||||||
|
|
Loading…
Reference in a new issue