mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-21 08:19:28 +00:00
ASoC: topology: Prevent use-after-free in snd_soc_get_pcm_runtime()
remove_link() is currently calling snd_soc_remove_dai_link() after it has already freed the memory for the link name. But this is later read from snd_soc_get_pcm_runtime() causing a KASAN use-after-free warning. Reorder the cleanups to fix this issue. Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Signed-off-by: Dragos Tarcatu <dragos_tarcatu@mentor.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Link: https://lore.kernel.org/r/20191204210447.11701-4-pierre-louis.bossart@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
parent
77fffa7422
commit
dd836ddf4e
1 changed files with 3 additions and 3 deletions
|
@ -548,12 +548,12 @@ static void remove_link(struct snd_soc_component *comp,
|
|||
if (dobj->ops && dobj->ops->link_unload)
|
||||
dobj->ops->link_unload(comp, dobj);
|
||||
|
||||
list_del(&dobj->list);
|
||||
snd_soc_remove_dai_link(comp->card, link);
|
||||
|
||||
kfree(link->name);
|
||||
kfree(link->stream_name);
|
||||
kfree(link->cpus->dai_name);
|
||||
|
||||
list_del(&dobj->list);
|
||||
snd_soc_remove_dai_link(comp->card, link);
|
||||
kfree(link);
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue