mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-07 00:59:06 +00:00
staging: slicoss: constify ethtool_ops structures
Check for ethtool_ops structures that are only stored in the ethtool_ops field of a net_device structure or passed as the second argument to netdev_set_default_ethtool_ops. These contexts are declared const, so ethtool_ops structures that have these properties can be declared as const also. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r disable optional_qualifier@ identifier i; position p; @@ static struct ethtool_ops i@p = { ... }; @ok1@ identifier r.i; struct net_device e; position p; @@ e.ethtool_ops = &i@p; @ok2@ identifier r.i; expression e; position p; @@ netdev_set_default_ethtool_ops(e, &i@p) @bad@ position p != {r.p,ok1.p,ok2.p}; identifier r.i; @@ i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct ethtool_ops i = { ... }; // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
0ca6d8e744
commit
dda3e26501
1 changed files with 2 additions and 2 deletions
|
@ -124,7 +124,7 @@ static const struct pci_device_id slic_pci_tbl[] = {
|
||||||
{ 0 }
|
{ 0 }
|
||||||
};
|
};
|
||||||
|
|
||||||
static struct ethtool_ops slic_ethtool_ops;
|
static const struct ethtool_ops slic_ethtool_ops;
|
||||||
|
|
||||||
MODULE_DEVICE_TABLE(pci, slic_pci_tbl);
|
MODULE_DEVICE_TABLE(pci, slic_pci_tbl);
|
||||||
|
|
||||||
|
@ -3128,7 +3128,7 @@ static void __exit slic_module_cleanup(void)
|
||||||
pci_unregister_driver(&slic_driver);
|
pci_unregister_driver(&slic_driver);
|
||||||
}
|
}
|
||||||
|
|
||||||
static struct ethtool_ops slic_ethtool_ops = {
|
static const struct ethtool_ops slic_ethtool_ops = {
|
||||||
.get_coalesce = slic_get_coalesce,
|
.get_coalesce = slic_get_coalesce,
|
||||||
.set_coalesce = slic_set_coalesce
|
.set_coalesce = slic_set_coalesce
|
||||||
};
|
};
|
||||||
|
|
Loading…
Reference in a new issue