mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-29 23:53:32 +00:00
pinctrl: renesas: checker: Fix miscalculation of number of states
The checker failed to validate all enum IDs in the description of a
register with fixed-width register fields, due to a miscalculation of
the number of described states: each register field of n bits can have
"1 << n" possible states, not "1".
Increase SH_PFC_MAX_ENUMS accordingly, now more enum IDs are checked
(SH-Mobile AG5 has more than 4000 enum IDs defined).
Fixes: 12d057bad6
("pinctrl: sh-pfc: checker: Add check for enum ID conflicts")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/6d8a6a05564f38f9d20464c1c17f96e52740cf6a.1645460429.git.geert+renesas@glider.be
This commit is contained in:
parent
4704797eb2
commit
de9b861018
1 changed files with 3 additions and 2 deletions
|
@ -741,7 +741,7 @@ static int sh_pfc_suspend_init(struct sh_pfc *pfc) { return 0; }
|
|||
|
||||
#ifdef DEBUG
|
||||
#define SH_PFC_MAX_REGS 300
|
||||
#define SH_PFC_MAX_ENUMS 3000
|
||||
#define SH_PFC_MAX_ENUMS 5000
|
||||
|
||||
static unsigned int sh_pfc_errors __initdata;
|
||||
static unsigned int sh_pfc_warnings __initdata;
|
||||
|
@ -875,7 +875,8 @@ static void __init sh_pfc_check_cfg_reg(const char *drvname,
|
|||
GENMASK(cfg_reg->reg_width - 1, 0));
|
||||
|
||||
if (cfg_reg->field_width) {
|
||||
n = cfg_reg->reg_width / cfg_reg->field_width;
|
||||
fw = cfg_reg->field_width;
|
||||
n = (cfg_reg->reg_width / fw) << fw;
|
||||
/* Skip field checks (done at build time) */
|
||||
goto check_enum_ids;
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue