mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-29 23:53:32 +00:00
ASoC: tegra: Fix reference count leaks.
Calling pm_runtime_get_sync increments the counter even in case of failure, causing incorrect ref count if pm_runtime_put is not called in error handling paths. Call pm_runtime_put if pm_runtime_get_sync fails. Signed-off-by: Qiushi Wu <wu000273@umn.edu> Reviewed-by: Jon Hunter <jonathanh@nvidia.com> Link: https://lore.kernel.org/r/20200613204422.24484-1-wu000273@umn.edu Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
parent
668b1508cf
commit
deca195383
2 changed files with 6 additions and 2 deletions
|
@ -643,8 +643,10 @@ static int tegra30_ahub_resume(struct device *dev)
|
|||
int ret;
|
||||
|
||||
ret = pm_runtime_get_sync(dev);
|
||||
if (ret < 0)
|
||||
if (ret < 0) {
|
||||
pm_runtime_put(dev);
|
||||
return ret;
|
||||
}
|
||||
ret = regcache_sync(ahub->regmap_ahub);
|
||||
ret |= regcache_sync(ahub->regmap_apbif);
|
||||
pm_runtime_put(dev);
|
||||
|
|
|
@ -567,8 +567,10 @@ static int tegra30_i2s_resume(struct device *dev)
|
|||
int ret;
|
||||
|
||||
ret = pm_runtime_get_sync(dev);
|
||||
if (ret < 0)
|
||||
if (ret < 0) {
|
||||
pm_runtime_put(dev);
|
||||
return ret;
|
||||
}
|
||||
ret = regcache_sync(i2s->regmap);
|
||||
pm_runtime_put(dev);
|
||||
|
||||
|
|
Loading…
Reference in a new issue