usb: Clarify expected behavior of dev_bin_attrs_are_visible()
The commit "usb: Export BOS descriptor to sysfs" added a binary attribute group to sysfs. It doesn't check if the descriptors attribute should be visible, which is by design and not an oversight. Update a comment so that it better explains this in the dev_bin_attrs_are_visible() function. Signed-off-by: Elbert Mai <code@elbertmai.com> Link: https://lore.kernel.org/r/20240306001503.313028-1-code@elbertmai.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
28cbed4960
commit
dfea18989a
|
@ -929,8 +929,11 @@ static umode_t dev_bin_attrs_are_visible(struct kobject *kobj,
|
||||||
struct device *dev = kobj_to_dev(kobj);
|
struct device *dev = kobj_to_dev(kobj);
|
||||||
struct usb_device *udev = to_usb_device(dev);
|
struct usb_device *udev = to_usb_device(dev);
|
||||||
|
|
||||||
/* All USB devices have a device descriptor, so the descriptors
|
/*
|
||||||
* attribute always exists. No need to check for its visibility.
|
* There's no need to check if the descriptors attribute should
|
||||||
|
* be visible because all devices have a device descriptor. The
|
||||||
|
* bos_descriptors attribute should be visible if and only if
|
||||||
|
* the device has a BOS, so check if it exists here.
|
||||||
*/
|
*/
|
||||||
if (a == &bin_attr_bos_descriptors) {
|
if (a == &bin_attr_bos_descriptors) {
|
||||||
if (udev->bos == NULL)
|
if (udev->bos == NULL)
|
||||||
|
|
Loading…
Reference in New Issue