mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-05 02:19:51 +00:00
usb: host: ehci-spear: Use devm_ioremap_resource instead of devm_ioremap
Using devm_ioremap_resource() API should actually be preferred over devm_ioremap(), since the former request the mem region first and then gives back the ioremap'ed memory pointer. devm_ioremap_resource() calls request_mem_region(), therby preventing other drivers to make any overlapping call to the same region. Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> Acked-by: Alan Stern <stern@rowland.harvard.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
40a5ec988c
commit
e0f77a91ee
1 changed files with 3 additions and 10 deletions
|
@ -106,16 +106,9 @@ static int spear_ehci_hcd_drv_probe(struct platform_device *pdev)
|
||||||
|
|
||||||
hcd->rsrc_start = res->start;
|
hcd->rsrc_start = res->start;
|
||||||
hcd->rsrc_len = resource_size(res);
|
hcd->rsrc_len = resource_size(res);
|
||||||
if (!devm_request_mem_region(&pdev->dev, hcd->rsrc_start, hcd->rsrc_len,
|
hcd->regs = devm_ioremap_resource(&pdev->dev, res);
|
||||||
driver->description)) {
|
if (IS_ERR(hcd->regs)) {
|
||||||
retval = -EBUSY;
|
retval = PTR_ERR(hcd->regs);
|
||||||
goto err_put_hcd;
|
|
||||||
}
|
|
||||||
|
|
||||||
hcd->regs = devm_ioremap(&pdev->dev, hcd->rsrc_start, hcd->rsrc_len);
|
|
||||||
if (hcd->regs == NULL) {
|
|
||||||
dev_dbg(&pdev->dev, "error mapping memory\n");
|
|
||||||
retval = -ENOMEM;
|
|
||||||
goto err_put_hcd;
|
goto err_put_hcd;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue