mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-27 11:19:37 +00:00
media: imx-jpeg: fix a bug of accessing array out of bounds
[ Upstream commit 97558d170a
]
When error occurs in parsing jpeg, the slot isn't acquired yet, it may
be the default value MXC_MAX_SLOTS.
If the driver access the slot using the incorrect slot number, it will
access array out of bounds.
The result is the driver will change num_domains, which follows
slot_data in struct mxc_jpeg_dev.
Then the driver won't detach the pm domain at rmmod, which will lead to
kernel panic when trying to insmod again.
Signed-off-by: Ming Qian <ming.qian@nxp.com>
Reviewed-by: Mirela Rabulea <mirela.rabulea@nxp.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
f0030a55be
commit
e209e6db2e
1 changed files with 0 additions and 1 deletions
|
@ -954,7 +954,6 @@ static void mxc_jpeg_device_run(void *priv)
|
|||
jpeg_src_buf->jpeg_parse_error = true;
|
||||
}
|
||||
if (jpeg_src_buf->jpeg_parse_error) {
|
||||
jpeg->slot_data[ctx->slot].used = false;
|
||||
v4l2_m2m_src_buf_remove(ctx->fh.m2m_ctx);
|
||||
v4l2_m2m_dst_buf_remove(ctx->fh.m2m_ctx);
|
||||
v4l2_m2m_buf_done(src_buf, VB2_BUF_STATE_ERROR);
|
||||
|
|
Loading…
Reference in a new issue