mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-02 15:18:19 +00:00
net: hns3: refactor out hclge_set_rss_tuple()
To make it more readable and maintainable, split hclge_set_rss_tuple() into two parts. Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
eb0faf32b8
commit
e291eff3bc
1 changed files with 29 additions and 13 deletions
|
@ -4501,22 +4501,12 @@ static u8 hclge_get_rss_hash_bits(struct ethtool_rxnfc *nfc)
|
||||||
return hash_sets;
|
return hash_sets;
|
||||||
}
|
}
|
||||||
|
|
||||||
static int hclge_set_rss_tuple(struct hnae3_handle *handle,
|
static int hclge_init_rss_tuple_cmd(struct hclge_vport *vport,
|
||||||
struct ethtool_rxnfc *nfc)
|
struct ethtool_rxnfc *nfc,
|
||||||
|
struct hclge_rss_input_tuple_cmd *req)
|
||||||
{
|
{
|
||||||
struct hclge_vport *vport = hclge_get_vport(handle);
|
|
||||||
struct hclge_dev *hdev = vport->back;
|
struct hclge_dev *hdev = vport->back;
|
||||||
struct hclge_rss_input_tuple_cmd *req;
|
|
||||||
struct hclge_desc desc;
|
|
||||||
u8 tuple_sets;
|
u8 tuple_sets;
|
||||||
int ret;
|
|
||||||
|
|
||||||
if (nfc->data & ~(RXH_IP_SRC | RXH_IP_DST |
|
|
||||||
RXH_L4_B_0_1 | RXH_L4_B_2_3))
|
|
||||||
return -EINVAL;
|
|
||||||
|
|
||||||
req = (struct hclge_rss_input_tuple_cmd *)desc.data;
|
|
||||||
hclge_cmd_setup_basic_desc(&desc, HCLGE_OPC_RSS_INPUT_TUPLE, false);
|
|
||||||
|
|
||||||
req->ipv4_tcp_en = vport->rss_tuple_sets.ipv4_tcp_en;
|
req->ipv4_tcp_en = vport->rss_tuple_sets.ipv4_tcp_en;
|
||||||
req->ipv4_udp_en = vport->rss_tuple_sets.ipv4_udp_en;
|
req->ipv4_udp_en = vport->rss_tuple_sets.ipv4_udp_en;
|
||||||
|
@ -4561,6 +4551,32 @@ static int hclge_set_rss_tuple(struct hnae3_handle *handle,
|
||||||
return -EINVAL;
|
return -EINVAL;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
static int hclge_set_rss_tuple(struct hnae3_handle *handle,
|
||||||
|
struct ethtool_rxnfc *nfc)
|
||||||
|
{
|
||||||
|
struct hclge_vport *vport = hclge_get_vport(handle);
|
||||||
|
struct hclge_dev *hdev = vport->back;
|
||||||
|
struct hclge_rss_input_tuple_cmd *req;
|
||||||
|
struct hclge_desc desc;
|
||||||
|
int ret;
|
||||||
|
|
||||||
|
if (nfc->data & ~(RXH_IP_SRC | RXH_IP_DST |
|
||||||
|
RXH_L4_B_0_1 | RXH_L4_B_2_3))
|
||||||
|
return -EINVAL;
|
||||||
|
|
||||||
|
req = (struct hclge_rss_input_tuple_cmd *)desc.data;
|
||||||
|
hclge_cmd_setup_basic_desc(&desc, HCLGE_OPC_RSS_INPUT_TUPLE, false);
|
||||||
|
|
||||||
|
ret = hclge_init_rss_tuple_cmd(vport, nfc, req);
|
||||||
|
if (ret) {
|
||||||
|
dev_err(&hdev->pdev->dev,
|
||||||
|
"failed to init rss tuple cmd, ret = %d\n", ret);
|
||||||
|
return ret;
|
||||||
|
}
|
||||||
|
|
||||||
ret = hclge_cmd_send(&hdev->hw, &desc, 1);
|
ret = hclge_cmd_send(&hdev->hw, &desc, 1);
|
||||||
if (ret) {
|
if (ret) {
|
||||||
dev_err(&hdev->pdev->dev,
|
dev_err(&hdev->pdev->dev,
|
||||||
|
|
Loading…
Reference in a new issue