mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-10-30 08:02:30 +00:00
Code Issues Releases Wiki Activity

staging: speakup: signedness bug in spk_ttyio_in_nowait()

Browse source 
On most of the common arches char is signed so it can't ever == 0xff.
Let's fix this by making it a u8.

Fixes: 6b9ad1c742 ("staging: speakup: add send_xchar, tiocmset and input functionality for tty")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dan Carpenter 2017-05-20 00:27:18 +03:00 committed by Greg Kroah-Hartman
parent d70dd24521
commit e45423d76f
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/staging/speakup/spk_ttyio.c
View file

@ -220,7 +220,7 @@ static unsigned char spk_ttyio_in(void)
static unsigned char spk_ttyio_in_nowait(void)
{
char rv = ttyio_in(0);
u8 rv = ttyio_in(0);
return (rv == 0xff) ? 0 : rv;
}