net/tls: don't log errors every time offload can't proceed
Currently when CONFIG_TLS_DEVICE is set each time kTLS connection is opened and the offload is not successful (either because the underlying device doesn't support it or e.g. it's tables are full) a rate limited error will be printed to the logs. There is nothing wrong with failing TLS offload. SW path will process the packets just fine, drop the noisy messages. Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> Reviewed-by: Simon Horman <simon.horman@netronome.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
30e5a9a5ba
commit
e49d268db9
|
@ -865,8 +865,6 @@ int tls_set_device_offload_rx(struct sock *sk, struct tls_context *ctx)
|
||||||
}
|
}
|
||||||
|
|
||||||
if (!(netdev->features & NETIF_F_HW_TLS_RX)) {
|
if (!(netdev->features & NETIF_F_HW_TLS_RX)) {
|
||||||
pr_err_ratelimited("%s: netdev %s with no TLS offload\n",
|
|
||||||
__func__, netdev->name);
|
|
||||||
rc = -ENOTSUPP;
|
rc = -ENOTSUPP;
|
||||||
goto release_netdev;
|
goto release_netdev;
|
||||||
}
|
}
|
||||||
|
@ -894,11 +892,8 @@ int tls_set_device_offload_rx(struct sock *sk, struct tls_context *ctx)
|
||||||
rc = netdev->tlsdev_ops->tls_dev_add(netdev, sk, TLS_OFFLOAD_CTX_DIR_RX,
|
rc = netdev->tlsdev_ops->tls_dev_add(netdev, sk, TLS_OFFLOAD_CTX_DIR_RX,
|
||||||
&ctx->crypto_recv.info,
|
&ctx->crypto_recv.info,
|
||||||
tcp_sk(sk)->copied_seq);
|
tcp_sk(sk)->copied_seq);
|
||||||
if (rc) {
|
if (rc)
|
||||||
pr_err_ratelimited("%s: The netdev has refused to offload this socket\n",
|
|
||||||
__func__);
|
|
||||||
goto free_sw_resources;
|
goto free_sw_resources;
|
||||||
}
|
|
||||||
|
|
||||||
tls_device_attach(ctx, sk, netdev);
|
tls_device_attach(ctx, sk, netdev);
|
||||||
goto release_netdev;
|
goto release_netdev;
|
||||||
|
|
Loading…
Reference in New Issue