mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-24 09:50:04 +00:00
iio: adc: ti_am335x_adc: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230919174931.1417681-26-u.kleine-koenig@pengutronix.de Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This commit is contained in:
parent
794c760fd3
commit
e4bd0e6040
1 changed files with 2 additions and 4 deletions
|
@ -681,7 +681,7 @@ static int tiadc_probe(struct platform_device *pdev)
|
|||
return err;
|
||||
}
|
||||
|
||||
static int tiadc_remove(struct platform_device *pdev)
|
||||
static void tiadc_remove(struct platform_device *pdev)
|
||||
{
|
||||
struct iio_dev *indio_dev = platform_get_drvdata(pdev);
|
||||
struct tiadc_device *adc_dev = iio_priv(indio_dev);
|
||||
|
@ -697,8 +697,6 @@ static int tiadc_remove(struct platform_device *pdev)
|
|||
|
||||
step_en = get_adc_step_mask(adc_dev);
|
||||
am335x_tsc_se_clr(adc_dev->mfd_tscadc, step_en);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static int tiadc_suspend(struct device *dev)
|
||||
|
@ -747,7 +745,7 @@ static struct platform_driver tiadc_driver = {
|
|||
.of_match_table = ti_adc_dt_ids,
|
||||
},
|
||||
.probe = tiadc_probe,
|
||||
.remove = tiadc_remove,
|
||||
.remove_new = tiadc_remove,
|
||||
};
|
||||
module_platform_driver(tiadc_driver);
|
||||
|
||||
|
|
Loading…
Reference in a new issue