mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-02 07:04:24 +00:00
iommu/sun50i: Fix reset release
[ Upstream commit9ad0c1252e
] Reset signal is asserted by writing 0 to the corresponding locations of masters we want to reset. So in order to deassert all reset signals, we should write 1's to all locations. Current code writes 1's to locations of masters which were just reset which is good. However, at the same time it also writes 0's to other locations and thus asserts reset signals of remaining masters. Fix code by writing all 1's when we want to deassert all reset signals. This bug was discovered when working with Cedrus (video decoder). When it faulted, display went blank due to reset signal assertion. Fixes:4100b8c229
("iommu: Add Allwinner H6 IOMMU driver") Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com> Link: https://lore.kernel.org/r/20221025165415.307591-2-jernej.skrabec@gmail.com Signed-off-by: Joerg Roedel <jroedel@suse.de> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
97b280f84b
commit
e554123946
1 changed files with 2 additions and 1 deletions
|
@ -27,6 +27,7 @@
|
|||
#include <linux/types.h>
|
||||
|
||||
#define IOMMU_RESET_REG 0x010
|
||||
#define IOMMU_RESET_RELEASE_ALL 0xffffffff
|
||||
#define IOMMU_ENABLE_REG 0x020
|
||||
#define IOMMU_ENABLE_ENABLE BIT(0)
|
||||
|
||||
|
@ -893,7 +894,7 @@ static irqreturn_t sun50i_iommu_irq(int irq, void *dev_id)
|
|||
iommu_write(iommu, IOMMU_INT_CLR_REG, status);
|
||||
|
||||
iommu_write(iommu, IOMMU_RESET_REG, ~status);
|
||||
iommu_write(iommu, IOMMU_RESET_REG, status);
|
||||
iommu_write(iommu, IOMMU_RESET_REG, IOMMU_RESET_RELEASE_ALL);
|
||||
|
||||
spin_unlock(&iommu->iommu_lock);
|
||||
|
||||
|
|
Loading…
Reference in a new issue