mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-13 12:06:49 +00:00
net: ethernet: ezchip: fix error handling
[ Upstream commit0de449d599
] As documented at drivers/base/platform.c for platform_get_irq: * Gets an IRQ for a platform device and prints an error message if finding the * IRQ fails. Device drivers should check the return value for errors so as to * not pass a negative integer value to the request_irq() APIs. So, the driver should check that platform_get_irq() return value is _negative_, not that it's equal to zero, because -ENXIO (return value from request_irq() if irq was not found) will pass this check and it leads to passing negative irq to request_irq() Fixes:0dd0770936
("NET: Add ezchip ethernet driver") Signed-off-by: Pavel Skripkin <paskripkin@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
161f8b73da
commit
e72d9e4b98
1 changed files with 1 additions and 1 deletions
|
@ -610,7 +610,7 @@ static s32 nps_enet_probe(struct platform_device *pdev)
|
|||
|
||||
/* Get IRQ number */
|
||||
priv->irq = platform_get_irq(pdev, 0);
|
||||
if (!priv->irq) {
|
||||
if (priv->irq < 0) {
|
||||
dev_err(dev, "failed to retrieve <irq Rx-Tx> value from device tree\n");
|
||||
err = -ENODEV;
|
||||
goto out_netdev;
|
||||
|
|
Loading…
Reference in a new issue