mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-29 22:02:02 +00:00
platform/x86: hp-bioscfg: move mutex_lock() down in hp_add_other_attributes()
commit 5736aa9537
upstream.
attr_name_kobj's memory allocation is done with mutex_lock() held, this
is not needed.
Move allocation outside of mutex_lock() so unlock is not needed when
allocation fails.
Suggested-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20231113200742.3593548-2-harshit.m.mogalapalli@oracle.com
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
a9dc6f2e27
commit
e73ebb9355
1 changed files with 4 additions and 6 deletions
|
@ -592,13 +592,11 @@ static int hp_add_other_attributes(int attr_type)
|
|||
int ret;
|
||||
char *attr_name;
|
||||
|
||||
mutex_lock(&bioscfg_drv.mutex);
|
||||
|
||||
attr_name_kobj = kzalloc(sizeof(*attr_name_kobj), GFP_KERNEL);
|
||||
if (!attr_name_kobj) {
|
||||
ret = -ENOMEM;
|
||||
goto err_other_attr_init;
|
||||
}
|
||||
if (!attr_name_kobj)
|
||||
return -ENOMEM;
|
||||
|
||||
mutex_lock(&bioscfg_drv.mutex);
|
||||
|
||||
/* Check if attribute type is supported */
|
||||
switch (attr_type) {
|
||||
|
|
Loading…
Reference in a new issue