mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-27 19:29:37 +00:00
lpfc: fix memory leak and NULL dereference
kmalloc() can return NULL and without checking we were dereferencing it. Moreover if kmalloc succeeds but the function fails in other parts then we were returning the error code but we missed freeing lcb_context. While at it fixed one related checkpatch warning. Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> Reviewed-by: James Smart <james.smart@avagotech.com> Signed-off-by: James Bottomley <JBottomley@Odin.com>
This commit is contained in:
parent
481ebb3daa
commit
e795042365
1 changed files with 7 additions and 1 deletions
|
@ -5173,7 +5173,6 @@ lpfc_els_rcv_lcb(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb,
|
|||
rjt_err = LSRJT_CMD_UNSUPPORTED;
|
||||
goto rjt;
|
||||
}
|
||||
lcb_context = kmalloc(sizeof(struct lpfc_lcb_context), GFP_KERNEL);
|
||||
|
||||
if (phba->hba_flag & HBA_FCOE_MODE) {
|
||||
rjt_err = LSRJT_CMD_UNSUPPORTED;
|
||||
|
@ -5204,6 +5203,12 @@ lpfc_els_rcv_lcb(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb,
|
|||
goto rjt;
|
||||
}
|
||||
|
||||
lcb_context = kmalloc(sizeof(*lcb_context), GFP_KERNEL);
|
||||
if (!lcb_context) {
|
||||
rjt_err = LSRJT_UNABLE_TPC;
|
||||
goto rjt;
|
||||
}
|
||||
|
||||
state = (beacon->lcb_sub_command == LPFC_LCB_ON) ? 1 : 0;
|
||||
lcb_context->sub_command = beacon->lcb_sub_command;
|
||||
lcb_context->type = beacon->lcb_type;
|
||||
|
@ -5214,6 +5219,7 @@ lpfc_els_rcv_lcb(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb,
|
|||
if (lpfc_sli4_set_beacon(vport, lcb_context, state)) {
|
||||
lpfc_printf_vlog(ndlp->vport, KERN_ERR,
|
||||
LOG_ELS, "0193 failed to send mail box");
|
||||
kfree(lcb_context);
|
||||
lpfc_nlp_put(ndlp);
|
||||
rjt_err = LSRJT_UNABLE_TPC;
|
||||
goto rjt;
|
||||
|
|
Loading…
Reference in a new issue