mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-10-03 07:38:10 +00:00
Code Issues Releases Wiki Activity

staging: ks7010: avoid workqueue races

Browse source 
My Spectec SDW823 card oopsed when it was already inserted during boot.
When debugging this, I noticed that the card init was done in a seperate
workqueue which was only activated once in probe. After removing the
workqueue and calling the card init directly from probe, the OOPS went
away. It turned out this is the same OOPS which happened when removing
the card, so this seems possible now. Note: There is still a
not-understood card-removed event during boot, but at least it doesn't
crash anymore and the card will be re-probed right away.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Wolfram Sang 2016-05-31 12:56:18 +02:00 committed by Greg Kroah-Hartman
parent 72bf750007
commit e8593a8abf
3 changed files with 2 additions and 29 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
drivers/staging/ks7010/TODO
View file

@ -28,7 +28,6 @@ Now the TODOs:
should understand the change you submit.
- drop using a config file and use an upstream technique for configuration
- fix the 'card removal' event when card is inserted when booting
- driver crashes when removing the card
- check what other upstream wireless mechanisms can be used instead of the
custom ones here

28
drivers/staging/ks7010/ks7010_sdio.c
View file

@ -817,14 +817,8 @@ static int ks79xx_upload_firmware(ks_wlan_private *priv, struct ks_sdio_card *ca
return rc;
}
static void card_init_task(struct work_struct *work)
static void ks7010_card_init(struct ks_wlan_private *priv)
{
struct hw_info_t *hw;
struct ks_wlan_private *priv;
hw = container_of(work, struct hw_info_t, init_task);
priv = container_of(hw, struct ks_wlan_private, ks_wlan_hw);
DPRINTK(5,"\ncard_init_task()\n");
/* init_waitqueue_head(&priv->confirm_wait); */
@ -1052,23 +1046,11 @@ static int ks7910_sdio_probe(struct sdio_func *func, const struct sdio_device_id
goto error_free_read_buf;
}
priv->ks_wlan_hw.ks7010sdio_init = create_singlethread_workqueue("ks7010sdio_init");
if(!priv->ks_wlan_hw.ks7010sdio_init){
DPRINTK(1, "create_workqueue failed !!\n");
goto error_free_sdio_wq;
}
INIT_WORK(&priv->ks_wlan_hw.init_task, card_init_task);
INIT_DELAYED_WORK(&priv->ks_wlan_hw.rw_wq, ks7010_rw_function);
queue_work(priv->ks_wlan_hw.ks7010sdio_init, &priv->ks_wlan_hw.init_task);
ks7010_card_init(priv);
return 0;
error_free_sdio_wq:
flush_workqueue(priv->ks_wlan_hw.ks7010sdio_wq);
destroy_workqueue(priv->ks_wlan_hw.ks7010sdio_wq);
priv->ks_wlan_hw.ks7010sdio_wq = NULL;
error_free_read_buf:
kfree(priv->ks_wlan_hw.read_buf);
priv->ks_wlan_hw.read_buf = NULL;
@ -1139,12 +1121,6 @@ static void ks7910_sdio_remove(struct sdio_func *func)
}
DPRINTK(1, "destroy_workqueue(priv->ks_wlan_hw.ks7010sdio_wq);\n");
if(priv->ks_wlan_hw.ks7010sdio_init){
flush_workqueue(priv->ks_wlan_hw.ks7010sdio_init);
destroy_workqueue(priv->ks_wlan_hw.ks7010sdio_init);
}
DPRINTK(1, "destroy_workqueue(priv->ks_wlan_hw.ks7010sdio_init);\n");
hostif_exit(priv);
DPRINTK(1, "hostif_exit\n");

2
drivers/staging/ks7010/ks7010_sdio.h
View file

@ -96,8 +96,6 @@ struct hw_info_t {
struct ks_sdio_card *sdio_card;
struct completion ks7010_sdio_wait;
struct workqueue_struct *ks7010sdio_wq;
struct workqueue_struct *ks7010sdio_init;
struct work_struct init_task;
struct delayed_work rw_wq;
unsigned char *read_buf;
struct tasklet_struct rx_bh_task;