mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-01 22:54:01 +00:00
net_sched: cls_route: remove the right filter from hashtable
[ Upstream commitef299cc3fa
] route4_change() allocates a new filter and copies values from the old one. After the new filter is inserted into the hash table, the old filter should be removed and freed, as the final step of the update. However, the current code mistakenly removes the new one. This looks apparently wrong to me, and it causes double "free" and use-after-free too, as reported by syzbot. Reported-and-tested-by: syzbot+f9b32aaacd60305d9687@syzkaller.appspotmail.com Reported-and-tested-by: syzbot+2f8c233f131943d6056d@syzkaller.appspotmail.com Reported-and-tested-by: syzbot+9c2df9fd5e9445b74e01@syzkaller.appspotmail.com Fixes:1109c00547
("net: sched: RCU cls_route") Cc: Jamal Hadi Salim <jhs@mojatatu.com> Cc: Jiri Pirko <jiri@resnulli.us> Cc: John Fastabend <john.fastabend@gmail.com> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
efec582aa0
commit
ea3d6652c2
1 changed files with 2 additions and 2 deletions
|
@ -536,8 +536,8 @@ static int route4_change(struct net *net, struct sk_buff *in_skb,
|
|||
fp = &b->ht[h];
|
||||
for (pfp = rtnl_dereference(*fp); pfp;
|
||||
fp = &pfp->next, pfp = rtnl_dereference(*fp)) {
|
||||
if (pfp == f) {
|
||||
*fp = f->next;
|
||||
if (pfp == fold) {
|
||||
rcu_assign_pointer(*fp, fold->next);
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue