mirrors
/
linux-stable
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
1
0
Fork 0
Code Issues Releases Wiki Activity

sgi-xp: eliminate '>>>' in comments 

Comments in /drivers/misc/sgi-xp has been using '>>>' as a means to draw
attention to something that needs to be done or considered.  To avoid
colliding with git rejects, '>>>' will now be replaced by '!!!' to
indicate something to do, and by '???' to indicate something to be
considered.

Signed-off-by: Dean Nelson <dcn@sgi.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Dean Nelson 2008-07-29 22:34:14 -07:00 committed by Linus Torvalds
parent 8e85c23ef0
commit ea57f80c8c
9 changed files with 43 additions and 44 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/misc/sgi-xp/xp.h
View File

@ -21,7 +21,7 @@
#include <asm/sn/arch.h> #include <asm/sn/arch.h>
#endif #endif
/* >>> Add this #define to some linux header file some day. */ /* ??? Add this #define to some linux header file some day? */
#define BYTES_PER_WORD sizeof(void *) #define BYTES_PER_WORD sizeof(void *)
#ifdef USE_DBUG_ON #ifdef USE_DBUG_ON
@ -65,18 +65,13 @@
* other partition that is currently up. Over these channels, kernel-level * other partition that is currently up. Over these channels, kernel-level
* `users' can communicate with their counterparts on the other partitions. * `users' can communicate with their counterparts on the other partitions.
* *
>>> The following described limitation of a max of eight channels possible
>>> pertains only to ia64-sn2. THIS ISN'T TRUE SINCE I'M PLANNING TO JUST
>>> TIE INTO THE EXISTING MECHANISM ONCE THE CHANNEL MESSAGES ARE RECEIVED.
>>> THE 128-BYTE CACHELINE PERFORMANCE ISSUE IS TIED TO IA64-SN2.
*
* If the need for additional channels arises, one can simply increase * If the need for additional channels arises, one can simply increase
* XPC_MAX_NCHANNELS accordingly. If the day should come where that number * XPC_MAX_NCHANNELS accordingly. If the day should come where that number
* exceeds the absolute MAXIMUM number of channels possible (eight), then one * exceeds the absolute MAXIMUM number of channels possible (eight), then one
* will need to make changes to the XPC code to accommodate for this. * will need to make changes to the XPC code to accommodate for this.
* *
* The absolute maximum number of channels possible is currently limited to * The absolute maximum number of channels possible is limited to eight for
* eight for performance reasons. The internal cross partition structures * performance reasons on sn2 hardware. The internal cross partition structures
* require sixteen bytes per channel, and eight allows all of this * require sixteen bytes per channel, and eight allows all of this
* interface-shared info to fit in one 128-byte cacheline. * interface-shared info to fit in one 128-byte cacheline.
*/ */

10
drivers/misc/sgi-xp/xp_sn2.c
View File

@ -87,11 +87,11 @@ xp_remote_memcpy_sn2(void *vdst, const void *psrc, size_t len)
{ {
bte_result_t ret; bte_result_t ret;
u64 pdst = ia64_tpa(vdst); u64 pdst = ia64_tpa(vdst);
/* >>> What are the rules governing the src and dst addresses passed in? /* ??? What are the rules governing the src and dst addresses passed in?
* >>> Currently we're assuming that dst is a virtual address and src * ??? Currently we're assuming that dst is a virtual address and src
* >>> is a physical address, is this appropriate? Can we allow them to * ??? is a physical address, is this appropriate? Can we allow them to
* >>> be whatever and we make the change here without damaging the * ??? be whatever and we make the change here without damaging the
* >>> addresses? * ??? addresses?
*/ */
/* /*

2
drivers/misc/sgi-xp/xp_uv.c
View File

@ -18,7 +18,7 @@
static enum xp_retval static enum xp_retval
xp_remote_memcpy_uv(void *vdst, const void *psrc, size_t len) xp_remote_memcpy_uv(void *vdst, const void *psrc, size_t len)
{ {
/* >>> this function needs fleshing out */ /* !!! this function needs fleshing out */
return xpUnsupported; return xpUnsupported;
} }

14
drivers/misc/sgi-xp/xpc.h
View File

@ -276,9 +276,12 @@ struct xpc_notify {
* There is an array of these structures for each remote partition. It is * There is an array of these structures for each remote partition. It is
* allocated at the time a partition becomes active. The array contains one * allocated at the time a partition becomes active. The array contains one
* of these structures for each potential channel connection to that partition. * of these structures for each potential channel connection to that partition.
*/
/*
* The following is sn2 only.
* *
>>> sn2 only!!! * Each channel structure manages two message queues (circular buffers).
* Each of these structures manages two message queues (circular buffers).
* They are allocated at the time a channel connection is made. One of * They are allocated at the time a channel connection is made. One of
* these message queues (local_msgqueue) holds the locally created messages * these message queues (local_msgqueue) holds the locally created messages
* that are destined for the remote partition. The other of these message * that are destined for the remote partition. The other of these message
@ -345,6 +348,7 @@ struct xpc_notify {
* new messages, by the clearing of the message flags of the acknowledged * new messages, by the clearing of the message flags of the acknowledged
* messages. * messages.
*/ */
struct xpc_channel_sn2 { struct xpc_channel_sn2 {
/* various flavors of local and remote Get/Put values */ /* various flavors of local and remote Get/Put values */
@ -359,7 +363,7 @@ struct xpc_channel_sn2 {
}; };
struct xpc_channel_uv { struct xpc_channel_uv {
/* >>> code is coming */ /* !!! code is coming */
}; };
struct xpc_channel { struct xpc_channel {
@ -500,7 +504,7 @@ xpc_any_msg_chctl_flags_set(union xpc_channel_ctl_flags *chctl)
} }
/* /*
* Manages channels on a partition basis. There is one of these structures * Manage channels on a partition basis. There is one of these structures
* for each partition (a partition will never utilize the structure that * for each partition (a partition will never utilize the structure that
* represents itself). * represents itself).
*/ */
@ -535,7 +539,7 @@ struct xpc_partition_sn2 {
}; };
struct xpc_partition_uv { struct xpc_partition_uv {
/* >>> code is coming */ /* !!! code is coming */
}; };
struct xpc_partition { struct xpc_partition {

2
drivers/misc/sgi-xp/xpc_channel.c
View File

@ -129,7 +129,7 @@ xpc_process_disconnect(struct xpc_channel *ch, unsigned long *irq_flags)
/* wake those waiting for notify completion */ /* wake those waiting for notify completion */
if (atomic_read(&ch->n_to_notify) > 0) { if (atomic_read(&ch->n_to_notify) > 0) {
/* >>> we do callout while holding ch->lock */ /* we do callout while holding ch->lock, callout can't block */
xpc_notify_senders_of_disconnect(ch); xpc_notify_senders_of_disconnect(ch);
} }

2
drivers/misc/sgi-xp/xpc_partition.c
View File

@ -91,7 +91,7 @@ xpc_get_rsvd_page_pa(int nasid)
if (status != SALRET_MORE_PASSES) if (status != SALRET_MORE_PASSES)
break; break;
/* >>> L1_CACHE_ALIGN() is only a sn2-bte_copy requirement */ /* !!! L1_CACHE_ALIGN() is only a sn2-bte_copy requirement */
if (L1_CACHE_ALIGN(len) > buf_len) { if (L1_CACHE_ALIGN(len) > buf_len) {
kfree(buf_base); kfree(buf_base);
buf_len = L1_CACHE_ALIGN(len); buf_len = L1_CACHE_ALIGN(len);

8
drivers/misc/sgi-xp/xpc_sn2.c
View File

@ -75,7 +75,7 @@ xpc_allow_IPI_ops_sn2(void)
int node; int node;
int nasid; int nasid;
/* >>> The following should get moved into SAL. */ /* !!! The following should get moved into SAL. */
if (is_shub2()) { if (is_shub2()) {
xpc_sh2_IPI_access0_sn2 = xpc_sh2_IPI_access0_sn2 =
(u64)HUB_L((u64 *)LOCAL_MMR_ADDR(SH2_IPI_ACCESS0)); (u64)HUB_L((u64 *)LOCAL_MMR_ADDR(SH2_IPI_ACCESS0));
@ -118,7 +118,7 @@ xpc_disallow_IPI_ops_sn2(void)
int node; int node;
int nasid; int nasid;
/* >>> The following should get moved into SAL. */ /* !!! The following should get moved into SAL. */
if (is_shub2()) { if (is_shub2()) {
for_each_online_node(node) { for_each_online_node(node) {
nasid = cnodeid_to_nasid(node); nasid = cnodeid_to_nasid(node);
@ -1360,7 +1360,7 @@ xpc_teardown_infrastructure_sn2(struct xpc_partition *part)
* dst must be a cacheline aligned virtual address on this partition. * dst must be a cacheline aligned virtual address on this partition.
* cnt must be cacheline sized * cnt must be cacheline sized
*/ */
/* >>> Replace this function by call to xp_remote_memcpy() or bte_copy()? */ /* ??? Replace this function by call to xp_remote_memcpy() or bte_copy()? */
static enum xp_retval static enum xp_retval
xpc_pull_remote_cachelines_sn2(struct xpc_partition *part, void *dst, xpc_pull_remote_cachelines_sn2(struct xpc_partition *part, void *dst,
const void *src, size_t cnt) const void *src, size_t cnt)
@ -2242,7 +2242,7 @@ xpc_send_msg_sn2(struct xpc_channel *ch, u32 flags, void *payload,
notify->key = key; notify->key = key;
notify->type = notify_type; notify->type = notify_type;
/* >>> is a mb() needed here? */ /* ??? Is a mb() needed here? */
if (ch->flags & XPC_C_DISCONNECTING) { if (ch->flags & XPC_C_DISCONNECTING) {
/* /*

32
drivers/misc/sgi-xp/xpc_uv.c
View File

@ -15,8 +15,8 @@
#include <linux/kernel.h> #include <linux/kernel.h>
/* >>> #include <gru/grukservices.h> */ /* !!! #include <gru/grukservices.h> */
/* >>> uv_gpa() is defined in <gru/grukservices.h> */ /* !!! uv_gpa() is defined in <gru/grukservices.h> */
#define uv_gpa(_a) ((unsigned long)_a) #define uv_gpa(_a) ((unsigned long)_a)
#include "xpc.h" #include "xpc.h"
@ -29,16 +29,16 @@ static void
xpc_send_local_activate_IRQ_uv(struct xpc_partition *part) xpc_send_local_activate_IRQ_uv(struct xpc_partition *part)
{ {
/* /*
* >>> make our side think that the remote parition sent an activate * !!! Make our side think that the remote parition sent an activate
* >>> message our way. Also do what the activate IRQ handler would * !!! message our way. Also do what the activate IRQ handler would
* >>> do had one really been sent. * !!! do had one really been sent.
*/ */
} }
static enum xp_retval static enum xp_retval
xpc_rsvd_page_init_uv(struct xpc_rsvd_page *rp) xpc_rsvd_page_init_uv(struct xpc_rsvd_page *rp)
{ {
/* >>> need to have established xpc_activate_mq earlier */ /* !!! need to have established xpc_activate_mq earlier */
rp->sn.activate_mq_gpa = uv_gpa(xpc_activate_mq); rp->sn.activate_mq_gpa = uv_gpa(xpc_activate_mq);
return xpSuccess; return xpSuccess;
} }
@ -46,7 +46,7 @@ xpc_rsvd_page_init_uv(struct xpc_rsvd_page *rp)
static void static void
xpc_increment_heartbeat_uv(void) xpc_increment_heartbeat_uv(void)
{ {
/* >>> send heartbeat msg to xpc_heartbeating_to_mask partids */ /* !!! send heartbeat msg to xpc_heartbeating_to_mask partids */
} }
static void static void
@ -59,7 +59,7 @@ xpc_heartbeat_init_uv(void)
static void static void
xpc_heartbeat_exit_uv(void) xpc_heartbeat_exit_uv(void)
{ {
/* >>> send heartbeat_offline msg to xpc_heartbeating_to_mask partids */ /* !!! send heartbeat_offline msg to xpc_heartbeating_to_mask partids */
} }
static void static void
@ -70,9 +70,9 @@ xpc_request_partition_activation_uv(struct xpc_rsvd_page *remote_rp,
struct xpc_partition *part = &xpc_partitions[partid]; struct xpc_partition *part = &xpc_partitions[partid];
/* /*
* >>> setup part structure with the bits of info we can glean from the rp * !!! Setup part structure with the bits of info we can glean from the rp:
* >>> part->remote_rp_pa = remote_rp_pa; * !!! part->remote_rp_pa = remote_rp_pa;
* >>> part->sn.uv.activate_mq_gpa = remote_rp->sn.activate_mq_gpa; * !!! part->sn.uv.activate_mq_gpa = remote_rp->sn.activate_mq_gpa;
*/ */
xpc_send_local_activate_IRQ_uv(part); xpc_send_local_activate_IRQ_uv(part);
@ -91,7 +91,7 @@ xpc_request_partition_reactivation_uv(struct xpc_partition *part)
static enum xp_retval static enum xp_retval
xpc_setup_infrastructure_uv(struct xpc_partition *part) xpc_setup_infrastructure_uv(struct xpc_partition *part)
{ {
/* >>> this function needs fleshing out */ /* !!! this function needs fleshing out */
return xpUnsupported; return xpUnsupported;
} }
@ -102,28 +102,28 @@ xpc_setup_infrastructure_uv(struct xpc_partition *part)
static void static void
xpc_teardown_infrastructure_uv(struct xpc_partition *part) xpc_teardown_infrastructure_uv(struct xpc_partition *part)
{ {
/* >>> this function needs fleshing out */ /* !!! this function needs fleshing out */
return; return;
} }
static enum xp_retval static enum xp_retval
xpc_make_first_contact_uv(struct xpc_partition *part) xpc_make_first_contact_uv(struct xpc_partition *part)
{ {
/* >>> this function needs fleshing out */ /* !!! this function needs fleshing out */
return xpUnsupported; return xpUnsupported;
} }
static u64 static u64
xpc_get_chctl_all_flags_uv(struct xpc_partition *part) xpc_get_chctl_all_flags_uv(struct xpc_partition *part)
{ {
/* >>> this function needs fleshing out */ /* !!! this function needs fleshing out */
return 0UL; return 0UL;
} }
static struct xpc_msg * static struct xpc_msg *
xpc_get_deliverable_msg_uv(struct xpc_channel *ch) xpc_get_deliverable_msg_uv(struct xpc_channel *ch)
{ {
/* >>> this function needs fleshing out */ /* !!! this function needs fleshing out */
return NULL; return NULL;
} }

6
drivers/misc/sgi-xp/xpnet.c
View File

@ -229,9 +229,9 @@ xpnet_receive(short partid, int channel, struct xpnet_message *msg)
if (ret != xpSuccess) { if (ret != xpSuccess) {
/* /*
* >>> Need better way of cleaning skb. Currently skb * !!! Need better way of cleaning skb. Currently skb
* >>> appears in_use and we can't just call * !!! appears in_use and we can't just call
* >>> dev_kfree_skb. * !!! dev_kfree_skb.
*/ */
dev_err(xpnet, "xp_remote_memcpy(0x%p, 0x%p, 0x%hx) " dev_err(xpnet, "xp_remote_memcpy(0x%p, 0x%p, 0x%hx) "
"returned error=0x%x\n", (void *) "returned error=0x%x\n", (void *)