mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-28 15:20:41 +00:00
random: do not sign extend bytes for rotation when mixing
commit 0d9488ffbf
upstream.
By using `char` instead of `unsigned char`, certain platforms will sign
extend the byte when `w = rol32(*bytes++, input_rotate)` is called,
meaning that bit 7 is overrepresented when mixing. This isn't a real
problem (unless the mixer itself is already broken) since it's still
invertible, but it's not quite correct either. Fix this by using an
explicit unsigned type.
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
1f89b3175b
commit
eaa94d939f
1 changed files with 1 additions and 1 deletions
|
@ -549,7 +549,7 @@ static void _mix_pool_bytes(struct entropy_store *r, const void *in,
|
|||
unsigned long i, tap1, tap2, tap3, tap4, tap5;
|
||||
int input_rotate;
|
||||
int wordmask = r->poolinfo->poolwords - 1;
|
||||
const char *bytes = in;
|
||||
const unsigned char *bytes = in;
|
||||
__u32 w;
|
||||
|
||||
tap1 = r->poolinfo->tap1;
|
||||
|
|
Loading…
Reference in a new issue