mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-24 01:41:39 +00:00
qed: Fix a memory allocation failure test in 'qed_mcp_cmd_init()'
We allocate 'p_info->mfw_mb_cur' and 'p_info->mfw_mb_shadow' but we check 'p_info->mfw_mb_addr' instead of 'p_info->mfw_mb_cur'. 'p_info->mfw_mb_addr' is never 0, because it is initiliazed a few lines above in 'qed_load_mcp_offsets()'. Update the test and check the result of the 2 'kzalloc()' instead. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Acked-by: Tomer Tayar <Tomer.Tayar@cavium.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
b925ef37b0
commit
eb2a6b800c
1 changed files with 1 additions and 1 deletions
|
@ -253,7 +253,7 @@ int qed_mcp_cmd_init(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt)
|
|||
size = MFW_DRV_MSG_MAX_DWORDS(p_info->mfw_mb_length) * sizeof(u32);
|
||||
p_info->mfw_mb_cur = kzalloc(size, GFP_KERNEL);
|
||||
p_info->mfw_mb_shadow = kzalloc(size, GFP_KERNEL);
|
||||
if (!p_info->mfw_mb_shadow || !p_info->mfw_mb_addr)
|
||||
if (!p_info->mfw_mb_cur || !p_info->mfw_mb_shadow)
|
||||
goto err;
|
||||
|
||||
return 0;
|
||||
|
|
Loading…
Reference in a new issue